-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[Offload] Deprecate openmp
and offload
projects builds
#136314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: These are compiler runtimes are currently have weird support for projects / runtimes. We should depcrate this to where the only expected configuration is via a runtimes build. If the user wants a custom setup they can still use the standalone build. I remember there were some concerens around the OpenMP module file for `flang`. Were those resolved? Fixes: llvm#124014
ping. |
openmp
and offload
projectsopenmp
and offload
projects builds
jdoerfert
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove the "now, "
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2789 Here is the relevant piece of the build log for the reference
|
jyli0116
pushed a commit
to jyli0116/llvm-project
that referenced
this pull request
Apr 28, 2025
Summary: These are compiler runtimes are currently have weird support for projects / runtimes. We should depcrate this to where the only expected configuration is via a runtimes build. If the user wants a custom setup they can still use the standalone build. I remember there were some concerens around the OpenMP module file for `flang`. Were those resolved? Fixes: llvm#124014
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Summary: These are compiler runtimes are currently have weird support for projects / runtimes. We should depcrate this to where the only expected configuration is via a runtimes build. If the user wants a custom setup they can still use the standalone build. I remember there were some concerens around the OpenMP module file for `flang`. Were those resolved? Fixes: llvm#124014
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Summary: These are compiler runtimes are currently have weird support for projects / runtimes. We should depcrate this to where the only expected configuration is via a runtimes build. If the user wants a custom setup they can still use the standalone build. I remember there were some concerens around the OpenMP module file for `flang`. Were those resolved? Fixes: llvm#124014
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Summary: These are compiler runtimes are currently have weird support for projects / runtimes. We should depcrate this to where the only expected configuration is via a runtimes build. If the user wants a custom setup they can still use the standalone build. I remember there were some concerens around the OpenMP module file for `flang`. Were those resolved? Fixes: llvm#124014
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
Summary: These are compiler runtimes are currently have weird support for projects / runtimes. We should depcrate this to where the only expected configuration is via a runtimes build. If the user wants a custom setup they can still use the standalone build. I remember there were some concerens around the OpenMP module file for `flang`. Were those resolved? Fixes: llvm#124014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These are compiler runtimes are currently have weird support for
projects / runtimes. We should depcrate this to where the only expected
configuration is via a runtimes build. If the user wants a custom setup
they can still use the standalone build.
I remember there were some concerens around the OpenMP module file for
flang
. Were those resolved?Fixes: #124014