-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[mlir] Fix typo in CSE transform #137341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[mlir] Fix typo in CSE transform #137341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-mlir-core @llvm/pr-subscribers-mlir Author: bubblepipe (bubblepipe) Changes"Replace all uses, but do not remote the operation yet" should be "Replace all uses, but do not remove the operation yet". Full diff: https://github.com/llvm/llvm-project/pull/137341.diff 1 Files Affected:
diff --git a/mlir/lib/Transforms/CSE.cpp b/mlir/lib/Transforms/CSE.cpp
index 3affd88d158de..8e03f62894bab 100644
--- a/mlir/lib/Transforms/CSE.cpp
+++ b/mlir/lib/Transforms/CSE.cpp
@@ -140,7 +140,7 @@ void CSEDriver::replaceUsesAndDelete(ScopedMapTy &knownValues, Operation *op,
if (auto *rewriteListener =
dyn_cast_if_present<RewriterBase::Listener>(rewriter.getListener()))
rewriteListener->notifyOperationReplaced(op, existing);
- // Replace all uses, but do not remote the operation yet. This does not
+ // Replace all uses, but do not remove the operation yet. This does not
// notify the listener because the original op is not erased.
rewriter.replaceAllUsesWith(op->getResults(), existing->getResults());
opsToErase.push_back(op);
@@ -156,7 +156,7 @@ void CSEDriver::replaceUsesAndDelete(ScopedMapTy &knownValues, Operation *op,
if (all_of(v.getUses(), wasVisited))
rewriteListener->notifyOperationReplaced(op, existing);
- // Replace all uses, but do not remote the operation yet. This does not
+ // Replace all uses, but do not remove the operation yet. This does not
// notify the listener because the original op is not erased.
rewriter.replaceUsesWithIf(op->getResults(), existing->getResults(),
wasVisited);
|
j2kun
approved these changes
Apr 25, 2025
jyli0116
pushed a commit
to jyli0116/llvm-project
that referenced
this pull request
Apr 28, 2025
"Replace all uses, but do not _remote_ the operation yet" should be "Replace all uses, but do not _remove_ the operation yet".
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
"Replace all uses, but do not _remote_ the operation yet" should be "Replace all uses, but do not _remove_ the operation yet".
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
"Replace all uses, but do not _remote_ the operation yet" should be "Replace all uses, but do not _remove_ the operation yet".
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
"Replace all uses, but do not _remote_ the operation yet" should be "Replace all uses, but do not _remove_ the operation yet".
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
"Replace all uses, but do not _remote_ the operation yet" should be "Replace all uses, but do not _remove_ the operation yet".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Replace all uses, but do not remote the operation yet" should be "Replace all uses, but do not remove the operation yet".