Skip to content

[mlir] Fix typo in CSE transform #137341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

[mlir] Fix typo in CSE transform #137341

merged 1 commit into from
Apr 25, 2025

Conversation

bubblepipe
Copy link
Contributor

"Replace all uses, but do not remote the operation yet" should be "Replace all uses, but do not remove the operation yet".

@llvmbot llvmbot added mlir:core MLIR Core Infrastructure mlir labels Apr 25, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 25, 2025

@llvm/pr-subscribers-mlir-core

@llvm/pr-subscribers-mlir

Author: bubblepipe (bubblepipe)

Changes

"Replace all uses, but do not remote the operation yet" should be "Replace all uses, but do not remove the operation yet".


Full diff: https://github.com/llvm/llvm-project/pull/137341.diff

1 Files Affected:

  • (modified) mlir/lib/Transforms/CSE.cpp (+2-2)
diff --git a/mlir/lib/Transforms/CSE.cpp b/mlir/lib/Transforms/CSE.cpp
index 3affd88d158de..8e03f62894bab 100644
--- a/mlir/lib/Transforms/CSE.cpp
+++ b/mlir/lib/Transforms/CSE.cpp
@@ -140,7 +140,7 @@ void CSEDriver::replaceUsesAndDelete(ScopedMapTy &knownValues, Operation *op,
     if (auto *rewriteListener =
             dyn_cast_if_present<RewriterBase::Listener>(rewriter.getListener()))
       rewriteListener->notifyOperationReplaced(op, existing);
-    // Replace all uses, but do not remote the operation yet. This does not
+    // Replace all uses, but do not remove the operation yet. This does not
     // notify the listener because the original op is not erased.
     rewriter.replaceAllUsesWith(op->getResults(), existing->getResults());
     opsToErase.push_back(op);
@@ -156,7 +156,7 @@ void CSEDriver::replaceUsesAndDelete(ScopedMapTy &knownValues, Operation *op,
         if (all_of(v.getUses(), wasVisited))
           rewriteListener->notifyOperationReplaced(op, existing);
 
-    // Replace all uses, but do not remote the operation yet. This does not
+    // Replace all uses, but do not remove the operation yet. This does not
     // notify the listener because the original op is not erased.
     rewriter.replaceUsesWithIf(op->getResults(), existing->getResults(),
                                wasVisited);

@j2kun j2kun merged commit 3ce2d1e into llvm:main Apr 25, 2025
14 checks passed
jyli0116 pushed a commit to jyli0116/llvm-project that referenced this pull request Apr 28, 2025
"Replace all uses, but do not _remote_ the operation yet" should be
"Replace all uses, but do not _remove_ the operation yet".
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
"Replace all uses, but do not _remote_ the operation yet" should be
"Replace all uses, but do not _remove_ the operation yet".
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
"Replace all uses, but do not _remote_ the operation yet" should be
"Replace all uses, but do not _remove_ the operation yet".
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
"Replace all uses, but do not _remote_ the operation yet" should be
"Replace all uses, but do not _remove_ the operation yet".
Ankur-0429 pushed a commit to Ankur-0429/llvm-project that referenced this pull request May 9, 2025
"Replace all uses, but do not _remote_ the operation yet" should be
"Replace all uses, but do not _remove_ the operation yet".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir:core MLIR Core Infrastructure mlir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants