-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Fix Windows build #137414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JDevlieghere
merged 1 commit into
llvm:main
from
emrekultursay:fix_domain_socket_windows
Apr 25, 2025
Merged
Fix Windows build #137414
JDevlieghere
merged 1 commit into
llvm:main
from
emrekultursay:fix_domain_socket_windows
Apr 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows doesn't have domain sockets, so we must properly #ifdef the code that touches DomainSocket.
@llvm/pr-subscribers-lldb Author: Emre Kultursay (emrekultursay) ChangesWindows doesn't have domain sockets, so we must properly #ifdef the code that touches DomainSocket. Full diff: https://github.com/llvm/llvm-project/pull/137414.diff 1 Files Affected:
diff --git a/lldb/tools/lldb-server/lldb-platform.cpp b/lldb/tools/lldb-server/lldb-platform.cpp
index b9a85370d649c..10d79c63af994 100644
--- a/lldb/tools/lldb-server/lldb-platform.cpp
+++ b/lldb/tools/lldb-server/lldb-platform.cpp
@@ -469,6 +469,7 @@ int main_platform(int argc, char *argv[]) {
if (gdbserver_port) {
socket = std::make_unique<TCPSocket>(sockfd, /*should_close=*/true);
} else {
+#if LLDB_ENABLE_POSIX
llvm::Expected<std::unique_ptr<DomainSocket>> domain_socket =
DomainSocket::FromBoundNativeSocket(sockfd, /*should_close=*/true);
if (!domain_socket) {
@@ -477,6 +478,11 @@ int main_platform(int argc, char *argv[]) {
return socket_error;
}
socket = std::move(domain_socket.get());
+#else
+ WithColor::error() << "lldb-platform child: Unix domain sockets are not "
+ "supported on this platform.";
+ return socket_error;
+#endif
}
GDBRemoteCommunicationServerPlatform platform(socket->GetSocketProtocol(),
|
JDevlieghere
approved these changes
Apr 25, 2025
jyli0116
pushed a commit
to jyli0116/llvm-project
that referenced
this pull request
Apr 28, 2025
Windows doesn't have domain sockets, so we must properly #ifdef the code that touches DomainSocket. Fixes the windows build break introduced by Commit llvm@488eeb3
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Windows doesn't have domain sockets, so we must properly #ifdef the code that touches DomainSocket. Fixes the windows build break introduced by Commit llvm@488eeb3
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Windows doesn't have domain sockets, so we must properly #ifdef the code that touches DomainSocket. Fixes the windows build break introduced by Commit llvm@488eeb3
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Windows doesn't have domain sockets, so we must properly #ifdef the code that touches DomainSocket. Fixes the windows build break introduced by Commit llvm@488eeb3
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
Windows doesn't have domain sockets, so we must properly #ifdef the code that touches DomainSocket. Fixes the windows build break introduced by Commit llvm@488eeb3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows doesn't have domain sockets, so we must properly #ifdef the code that touches DomainSocket. Fixes the windows build break introduced by Commit 488eeb3