Skip to content

[CGData] Return ArrayRef<std::string> in getNames (NFC) #140675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kazutakahirata
Copy link
Contributor

All uses of getNames is read access to the list of names, so we can
just return ArrayRefstd::string. There is no need to make a copy as
we prepare a return value.

All uses of getNames is read access to the list of names, so we can
just return ArrayRef<std::string>.  There is no need to make a copy as
we prepare a return value.
@kazutakahirata kazutakahirata merged commit f8e2e70 into llvm:main May 20, 2025
11 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_drop_const_llvm_CGData2 branch May 20, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants