[MLIR][Linalg] Retire tile_to_scf_for
#65633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelini
requested review from
ftynse,
matthias-springer and
nicolasvasilache
|
Please let me know if you think this is the right direction, currently I marked the PR as RFC. |
|
Great, thank you! |
nicolasvasilache
approved these changes
Sep 7, 2023
chelini
changed the title
tile_to_scf_fortile_to_scf_for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
TileOpandTileToScfForOpuse the tiling interface and thetileUsingSCFForOpmethod. This duplication was introduced in 44cfea0 as a way to retirelinalg::tileLinalgOp,now there is not more need for this duplication, and it seems thattileOphas more recent changes, thus retireTileToScfForOp.