Skip to content

[Demangle] demangle builtin type transformations #65902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[Demangle] demangle builtin type transformations #65902

merged 2 commits into from
Sep 21, 2023

Conversation

HerrCai0907
Copy link
Contributor

Fixed: #62127 https://reviews.llvm.org/D116203 introduced several compiler builtin equivalents of the unary type traits. In some cases (e.g. template) those builtin will be dependent and need to be mangle.
This patch add the check for u{builtin}I{type}E to demangle it.

Reviewed By: rjmccall

Differential Revision: https://reviews.llvm.org/D148465

Fixed: #62127
https://reviews.llvm.org/D116203 introduced several compiler builtin
equivalents of the unary type traits. In some cases (e.g. template) those
builtin will be dependent and need to be mangle.
This patch add the check for `u{builtin}I{type}E` to demangle it.

Reviewed By: rjmccall

Differential Revision: https://reviews.llvm.org/D148465
@HerrCai0907 HerrCai0907 requested a review from a team as a code owner September 10, 2023 16:16
@llvmbot llvmbot added the libc++abi libc++abi C++ Runtime Library. Not libc++. label Sep 10, 2023
@shafik
Copy link
Collaborator

shafik commented Sep 10, 2023

It looks like in: #62127 I identified that this was brought in via: e9ef456

Do we need to add tests for the other builtins as well, just to verify that we don't have other issues? It is not obvious to me why this effects only __decay.

@HerrCai0907
Copy link
Contributor Author

@shafik Could it merge now?

@HerrCai0907 HerrCai0907 requested a review from shafik September 20, 2023 13:19
@HerrCai0907
Copy link
Contributor Author

merged due to already reviewed in phabricator

@HerrCai0907 HerrCai0907 merged commit 4bc4d51 into llvm:main Sep 21, 2023
@HerrCai0907 HerrCai0907 deleted the arcpatch-D148465 branch October 10, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++abi libc++abi C++ Runtime Library. Not libc++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clang generates symbol name which we can't demangle
3 participants