[lldb] Fix --persistent-result description #68128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default is not static, it depends on context. For `expression`, the default is true, but for `dwim-print`, the default is false.
|
@llvm/pr-subscribers-lldb ChangesThe default is not static, it depends on context. For rdar://116320377 Full diff: https://github.com/llvm/llvm-project/pull/68128.diff 1 Files Affected:
diff --git a/lldb/source/Commands/Options.td b/lldb/source/Commands/Options.td
index 04830b8b990efae..cfdeaabfa007743 100644
--- a/lldb/source/Commands/Options.td
+++ b/lldb/source/Commands/Options.td
@@ -390,7 +390,7 @@ let Command = "expression" in {
Arg<"Boolean">,
Desc<"Persist expression result in a variable for subsequent use. "
"Expression results will be labeled with $-prefixed variables, e.g. $0, "
- "$1, etc. Defaults to true.">;
+ "$1, etc.">;
}
let Command = "frame diag" in {
|
JDevlieghere
approved these changes
Oct 3, 2023
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 5, 2023
From llvm@40653b6 % git show 40653b6 commit 40653b6 Author: Dave Lee <[email protected]> Date: Tue Oct 3 16:21:52 2023 -0700 [lldb] Fix --persistent-result description (llvm#68128) The default is not static, it depends on context. For `expression`, the default is true, but for `dwim-print`, the default is false. rdar://116320377 diff --git a/lldb/source/Commands/Options.td b/lldb/source/Commands/Options.td index 04830b8..cfdeaab 100644 --- a/lldb/source/Commands/Options.td +++ b/lldb/source/Commands/Options.td @@ -390,7 +390,7 @@ let Command = "expression" in { Arg<"Boolean">, Desc<"Persist expression result in a variable for subsequent use. " "Expression results will be labeled with $-prefixed variables, e.g. $0, " - "$1, etc. Defaults to true.">; + "$1, etc.">; } let Command = "frame diag" in {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is not static, it depends on context. For
expression, the default is true, but fordwim-print, the default is false.rdar://116320377