[lldb] Build the TestRosetta.py executable with system stdlib #78370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a speculative fix for TestRosetta.py which is currently failing on Green Dragon. TestRosetta just makes sure we can debug an x86_64 process on Apple Silicon. However, we're failing to build the x86_64 test binary. The linker is failing with some warnings about libc++ and libunwind being build for arm64 while the target binary is x86_64. I'm going to try building with the system standard libraries instead of the just-built ones to workaround it.
bulbazord
requested review from
adrian-prantl,
felipepiovezan and
jasonmolenda
|
@llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) ChangesThis is a speculative fix for TestRosetta.py which is currently failing on Green Dragon. TestRosetta just makes sure we can debug an x86_64 process on Apple Silicon. However, we're failing to build the x86_64 test binary. The linker is failing with some warnings about libc++ and libunwind being build for arm64 while the target binary is x86_64. I'm going to try building with the system standard libraries instead of the just-built ones to workaround it. Full diff: https://github.com/llvm/llvm-project/pull/78370.diff 1 Files Affected:
diff --git a/lldb/test/API/macosx/rosetta/Makefile b/lldb/test/API/macosx/rosetta/Makefile
index 8dd53c8407e1634..40707da8f100772 100644
--- a/lldb/test/API/macosx/rosetta/Makefile
+++ b/lldb/test/API/macosx/rosetta/Makefile
@@ -1,4 +1,6 @@
C_SOURCES := main.c
override ARCH = x86_64
+USE_SYSTEM_STDLIB := 1
+
include Makefile.rules
|
JDevlieghere
approved these changes
Jan 17, 2024
felipepiovezan
approved these changes
Jan 17, 2024
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
…8370) This is a speculative fix for TestRosetta.py which is currently failing on Green Dragon. TestRosetta just makes sure we can debug an x86_64 process on Apple Silicon. However, we're failing to build the x86_64 test binary. The linker is failing with some warnings about libc++ and libunwind being build for arm64 while the target binary is x86_64. I'm going to try building with the system standard libraries instead of the just-built ones to workaround it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a speculative fix for TestRosetta.py which is currently failing on Green Dragon.
TestRosetta just makes sure we can debug an x86_64 process on Apple Silicon. However, we're failing to build the x86_64 test binary. The linker is failing with some warnings about libc++ and libunwind being build for arm64 while the target binary is x86_64. I'm going to try building with the system standard libraries instead of the just-built ones to workaround it.