[TableGen] Support type aliases via new keyword deftype #79570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
wangpc-pp
requested review from
fpetrogalli,
Artem-B and
jroelofs
and removed request for
fpetrogalli
Created using spr 1.3.4
Created using spr 1.3.4
jroelofs
reviewed
Jan 26, 2024
jroelofs
approved these changes
Jan 26, 2024
Artem-B
reviewed
Jan 26, 2024
Created using spr 1.3.4
Artem-B
approved these changes
Jan 29, 2024
topperc
reviewed
Jan 30, 2024
Created using spr 1.3.4
topperc
reviewed
Jan 30, 2024
nhaehnle
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Thanks, I think this fits nicely with the language.
The change has a check whether a deftype conflicts with a pre-existing class definition, but it does not check whether a class definition conflicts with a pre-existing type alias. Please add that. Apart from that, this LGTM.
Created using spr 1.3.4
wangpc-pp
deleted the
users/wangpc-pp/spr/tablegen-support-type-aliases-via-new-keyword-deftype
branch
agozillon
pushed a commit
to agozillon/llvm-project
that referenced
this pull request
Feb 5, 2024
We can use `deftype` (not using `typedef` here to be consistent with `def`, `defm`, `defset`, `defvar`, etc) to define type aliases. Currently, only primitive types and type aliases are supported to be the source type and `deftype` statements can only appear at the top level. Reviewers: fpetrogalli, Artem-B, nhaehnle, jroelofs Reviewed By: jroelofs, nhaehnle, Artem-B Pull Request: llvm#79570
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
deftype(not usingtypedefhere to be consistentwith
def,defm,defset,defvar, etc) to define type aliases.Currently, only primitive types and type aliases are supported to be
the source type and
deftypestatements can only appear at the toplevel.