Skip to content

[GlobalOpt] Don't resolve aliased ifuncs with undefined resolvees. #96220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024
Merged

[GlobalOpt] Don't resolve aliased ifuncs with undefined resolvees. #96220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion llvm/lib/Transforms/IPO/GlobalOpt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2458,7 +2458,9 @@ static bool OptimizeStaticIFuncs(Module &M) {
bool Changed = false;
for (GlobalIFunc &IF : M.ifuncs())
if (Function *Callee = hasSideeffectFreeStaticResolution(IF))
if (!IF.use_empty()) {
if (!IF.use_empty() &&
(!Callee->isDeclaration() ||
none_of(IF.users(), [](User *U) { return isa<GlobalAlias>(U); }))) {
IF.replaceAllUsesWith(Callee);
NumIFuncsResolved++;
Changed = true;
Expand Down
22 changes: 22 additions & 0 deletions llvm/test/Transforms/GlobalOpt/resolve-static-ifunc.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,15 @@ target triple = "aarch64-unknown-linux-gnu"
@trivial.ifunc = internal ifunc void (), ptr @trivial.resolver
;.
; CHECK: @unknown_condition = external local_unnamed_addr global i1
; CHECK: @alias_decl = weak_odr alias void (), ptr @aliased_decl.ifunc
; CHECK: @alias_def = weak_odr alias void (), ptr @aliased_def._Msimd
; CHECK: @external_ifunc.ifunc = dso_local ifunc void (), ptr @external_ifunc.resolver
; CHECK: @complex.ifunc = internal ifunc void (), ptr @complex.resolver
; CHECK: @sideeffects.ifunc = internal ifunc void (), ptr @sideeffects.resolver
; CHECK: @interposable_ifunc.ifunc = internal ifunc void (), ptr @interposable_ifunc.resolver
; CHECK: @interposable_resolver.ifunc = weak ifunc void (), ptr @interposable_resolver.resolver
; CHECK: @aliased_decl.ifunc = weak_odr ifunc void (), ptr @aliased_decl.resolver
; CHECK: @aliased_def.ifunc = weak_odr ifunc void (), ptr @aliased_def.resolver
;.
define ptr @trivial.resolver() {
ret ptr @trivial._Msimd
Expand Down Expand Up @@ -89,6 +93,20 @@ define void @interposable_resolver.default() {
ret void
}

@alias_decl = weak_odr alias void (), ptr @aliased_decl.ifunc
@aliased_decl.ifunc = weak_odr ifunc void (), ptr @aliased_decl.resolver
declare void @aliased_decl._Msimd()
define ptr @aliased_decl.resolver() {
ret ptr @aliased_decl._Msimd
}

@alias_def = weak_odr alias void (), ptr @aliased_def.ifunc
@aliased_def.ifunc = weak_odr ifunc void (), ptr @aliased_def.resolver
define void @aliased_def._Msimd() { ret void }
define ptr @aliased_def.resolver() {
ret ptr @aliased_def._Msimd
}

define void @caller() {
; CHECK-LABEL: define void @caller() local_unnamed_addr {
; CHECK-NEXT: call void @trivial._Msimd()
Expand All @@ -97,6 +115,8 @@ define void @caller() {
; CHECK-NEXT: call void @sideeffects.ifunc()
; CHECK-NEXT: call void @interposable_ifunc.ifunc()
; CHECK-NEXT: call void @interposable_resolver.ifunc()
; CHECK-NEXT: call void @aliased_decl.ifunc()
; CHECK-NEXT: call void @aliased_def._Msimd()
; CHECK-NEXT: ret void
;
call void @trivial.ifunc()
Expand All @@ -105,5 +125,7 @@ define void @caller() {
call void @sideeffects.ifunc()
call void @interposable_ifunc.ifunc()
call void @interposable_resolver.ifunc()
call void @aliased_decl.ifunc()
call void @aliased_def.ifunc()
ret void
}
Loading