-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[libc][libcxx] Support for building libc++ against LLVM libc #99287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7d7a788
[libc][libcxx] Support for building libc++ against LLVM libc
petrhosek 76e5e02
Introduce the LIBCXX_LIBC option
petrhosek c6ca8cf
Review feedback
petrhosek 1418ea8
Review feedback
petrhosek a27eaa4
Remove unnecessary changes
petrhosek 1777997
Change dependency visibility
petrhosek 9f90269
Update formatting
petrhosek 0cafc79
Merge remote-tracking branch 'origin/main' into libcxx-use-libc
petrhosek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#=============================================================================== | ||
# Define targets for linking against the selected C library | ||
# | ||
# After including this file, the following targets are defined: | ||
# - libcxx-libc-headers: An interface target that allows getting access to the | ||
# headers of the selected C library. | ||
# - libcxx-libc-shared: A target representing the selected shared C library. | ||
# - libcxx-libc-static: A target representing the selected static C library. | ||
#=============================================================================== | ||
|
||
# Link against a system-provided libc | ||
if (LIBCXX_LIBC STREQUAL "system") | ||
add_library(libcxx-libc-headers INTERFACE) | ||
|
||
add_library(libcxx-libc-static INTERFACE) | ||
add_library(libcxx-libc-shared INTERFACE) | ||
|
||
# Link against the in-tree LLVM libc | ||
elseif (LIBCXX_LIBC STREQUAL "llvm-libc") | ||
add_library(libcxx-libc-headers INTERFACE) | ||
target_link_libraries(libcxx-libc-headers INTERFACE libc-headers) | ||
if(CXX_SUPPORTS_NOSTDLIBINC_FLAG) | ||
target_compile_options(libcxx-libc-headers INTERFACE "-nostdlibinc") | ||
endif() | ||
|
||
add_library(libcxx-libc-static INTERFACE) | ||
if (TARGET libc) | ||
target_link_libraries(libcxx-libc-static INTERFACE libc) | ||
endif() | ||
if (TARGET libm) | ||
target_link_libraries(libcxx-libc-static INTERFACE libm) | ||
endif() | ||
if (CXX_SUPPORTS_NOLIBC_FLAG) | ||
target_link_options(libcxx-libc-static INTERFACE "-nolibc") | ||
endif() | ||
|
||
# TODO: There's no support for building LLVM libc as a shared library yet. | ||
add_library(libcxx-libc-shared INTERFACE) | ||
endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.