[AArch64][FMV] Add a non-comprehensive test for ACLE FMV #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilinpv
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Thanks for compiler-rt FMV tests! We are going to add more on runtime detection implementing __builtin_cpu_supports aarch64 part https://reviews.llvm.org/D153153 on top of recently merged llvm/llvm-project#68919
SingleSource/UnitTests/AArch64/acle-function-multi-versioning.c
Outdated
Show resolved
Hide resolved
SingleSource/UnitTests/AArch64/acle-function-multi-versioning.c
Outdated
Show resolved
Hide resolved
jroelofs
force-pushed
the
jroelofs/fmv-functional-test
branch
from
31ab960 to
719c9ed
Compare
jroelofs
force-pushed
the
jroelofs/fmv-functional-test
branch
from
719c9ed to
b0941c3
Compare
ilinpv
reviewed
Feb 2, 2024
SingleSource/UnitTests/AArch64/acle-function-multi-versioning.c
Outdated
Show resolved
Hide resolved
SingleSource/UnitTests/AArch64/acle-function-multi-versioning.c
Outdated
Show resolved
Hide resolved
ilinpv
reviewed
Feb 2, 2024
ilinpv
added a commit
to ilinpv/llvm-test-suite
that referenced
this pull request
Feb 21, 2024
Enabling Linux part of llvm#87
ilinpv
added a commit
that referenced
this pull request
Feb 23, 2024
* [AArch64][FMV] Enable tests for ACLE FMV on Linux. Enabling Linux part of #87 * Update SingleSource/UnitTests/AArch64/acle-fmv-features.c Co-authored-by: Jon Roelofs <[email protected]> --------- Co-authored-by: Jon Roelofs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the ones we currently have enabled via apple.inc in compiler-rt, as well as a couple that are not. Each test uses Function Multi Versioning to check for the presence or absence of each given feature, and subsequently exercises that feature if it is presumed to exist. For features that are not thought to exist by the FMV infra, it forks and attempts to try the feature anyway, expecting the resulting thread to die, thus affirming the inverse.