[MHLO] Init MHLO linear op patterns #1132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanyokwok
force-pushed
the
upstream-06-mhlo-matmul
branch
from
ce88297 to
6f3dfae
Compare
|
Ready for review @silvasean @ZihengJiang @Vremold @Yancey1989 |
tanyokwok
requested review from
Vremold,
ZihengJiang,
silvasean and
Yancey0623
and removed request for
Vremold and
ZihengJiang
tanyokwok
force-pushed
the
upstream-06-mhlo-matmul
branch
from
6f3dfae to
7c1ee6e
Compare
ZihengJiang
reviewed
Aug 2, 2022
There was a problem hiding this comment.
Should we rename this part to Linear.cpp to align with https://github.com/llvm/torch-mlir/blob/main/lib/Conversion/TorchToLinalg/Linear.cpp
Maybe let's remove all the "Op" suffix in the file names
tanyokwok
force-pushed
the
upstream-06-mhlo-matmul
branch
from
7c1ee6e to
8d0e35c
Compare
ZihengJiang
approved these changes
Aug 3, 2022
ZihengJiang
changed the title
|
Could you also add the file into the bazel build like this? #1148 |
added 4 commits
August 4, 2022 09:26
See RFC llvm#999 Co-authored-by: Bairen Yi [email protected] Co-authored-by: Jiawei Wu [email protected] Co-authored-by: Tianyou Guo [email protected] Co-authored-by: Xu Yan [email protected] Co-authored-by: Ziheng Jiang [email protected]
tanyokwok
force-pushed
the
upstream-06-mhlo-matmul
branch
from
8d0e35c to
19f6e52
Compare
Thanks! Done. |
|
Merged. Thanks @fortianyou |
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
* bump llvm-project to 881ff4e Signed-off-by: Liam Fitzpatrick <[email protected]> Co-authored-by: Alexandre Eichenberger <[email protected]> Co-authored-by: gongsu832 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See RFC #999
Co-authored-by: Bairen Yi [email protected]
Co-authored-by: Jiawei Wu [email protected]
Co-authored-by: Tianyou Guo [email protected]
Co-authored-by: Xu Yan [email protected]
Co-authored-by: Ziheng Jiang [email protected]