Skip to content

Dockerize and Cache Bazel {Local, CI} Builds #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

sjain-stanford
Copy link
Member

@sjain-stanford sjain-stanford commented Aug 17, 2022

This PR adds:

  • A minimal docker wrapper to the bazel GHA workflow to make it reproducible locally
  • Bazel cache to speed up GHA workflows (down to ~5 minutes from ~40+minutes)

This is a no-op for non-bazel workflows and an incremental improvement.

@silvasean
Copy link
Contributor

Should this have a development.md update?

Overall LGTM.

@sjain-stanford
Copy link
Member Author

Should this have a development.md update?

Thank you! I had a local commit, forgot to push. Done.

@sjain-stanford sjain-stanford merged commit 9c8b962 into llvm:main Aug 17, 2022
@sjain-stanford
Copy link
Member Author

I was sure it worked (e.g. https://github.com/sjain-stanford/torch-mlir/runs/7883322484?check_suite_focus=true), ... but apparently not on the main repo's VM runner. So I broke the bazel CI in an attempt to make it better :) Working on getting this back to green.

sjain-stanford added a commit that referenced this pull request Aug 18, 2022
This fixes a seeding issue with the [previous PR](#1240) where bazel build's GHA cache is not present to begin with and one of the commands (chown) fails on it. Should get the Bazel build back to green.
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
…vm#1240)

* Source code for fp32-dlf16 conversion

Signed-off-by: Joachim von Buttlar <[email protected]>

* Add stickify and enable constant propagation for zhigh ops

Signed-off-by: Tung D. Le <[email protected]>

* Use stride = 1 by default

Signed-off-by: Tung D. Le <[email protected]>

Co-authored-by: Joachim von Buttlar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants