Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #1697

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Update index.md #1697

merged 1 commit into from
Apr 3, 2025

Conversation

vijaynidhani
Copy link
Contributor

Port info is missing, also it required environment variable change in LocalStack to listen on port 80 by setting the environment variable: GATEWAY_LISTEN=:4566,:80,:443

Port info is missing, also it required environment variable change in LocalStack to listen on port 80 by setting the environment variable: GATEWAY_LISTEN=:4566,:80,:443
@vijaynidhani vijaynidhani requested a review from simonrw as a code owner March 18, 2025 05:15
Copy link

⚡️ Deploying PR Preview...

@simonrw simonrw requested a review from nik-localstack March 18, 2025 17:22
Copy link

@nik-localstack nik-localstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @vijaynidhani 🚀
Indeed these fields are now required after 4.2 version of localstack in parity to what is required in AWS

Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mention in the PR description that GATEWAY_LISTEN should be updated. Perhaps you can add a note to the elbv2 docs mentioning that if you want your load balancer to listen on port 80, then GATEWAY_LISTEN must include it?

This suggestion is not blocking to this PR, but I would like to see this added at some point cc @dfangl @nik-localstack

@quetzalliwrites quetzalliwrites merged commit 8608a94 into localstack:main Apr 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants