Description
Using the annotation @LocalstackDockerProperties we should be able to set "pullNewImage" to false - indeed it should be false by default.
However, I have found running this on Windows always attempts to pull a new image, regardless of the setting.
I believe this is due to the check for whether the image exists within cloud.localstack.docker.Container line 71 checks if the list of images contains the image name but does not account for Windows line endings within the ListImagesCommand.execute() method as the list is split on \n only, leaving a \r at the end of the name which is not on the expected fullImageName.
I only noticed this was the expected behaviour when I was trying to work around this issue and noticed that the option didn't work!
Steps to reproduce:
- Create a JUnit class annotated with:
@LocalstackDockerProperties(
imageTag = "0.12.11",
pullNewImage = false,
services = { "s3" }
)
- Run the JUnit
Expected:
The log message below is not produced:
cloud.localstack.docker.Container createLocalstackContainer
INFO: Pulling latest image...
Actual:
It is.