Get 100 log lines #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fetched number of log lines (10) was too low s.t. when a container took some time to boot the 404 messages from the request already took up too much space in the logs, and the `Ready.` token could not be detected. This commit increases the number of log lines to 100, so that this error should be alleviated, although it is of course not an optimal solution. It might make sense too simply fetch all logs (with a -1 paramter), and let the user overwrite this value.
|
LGTM, thanks for fixing this @AntonOellerer ! 👍 We'll release a new version to Maven Central shortly.. Thanks |
fripoli
added a commit
to fripoli/localstack-java-utils
that referenced
this pull request
Aug 1, 2021
* localstack-master: (27 commits) Added tests to show the exception on the SES client V2 release version v0.2.15 refactor logging config; fix Kinesis CBOR tests fix project setup and classpath for SDK v1/v2 utils fix awaiting results in tests using async clients adjust CI config to use new make targets; fix imports for SDK v1/v2 compatibility refactor classpath setup for v1/v2 SDKs; fall back to using edge port if port mapping cannot be determined from container add ability to get handler class name through "_HANDLER" environment variable like in real AWS (localstack#67) implement empty methods in `LambdaContext` (localstack#66) release version 0.2.13 increate number of scanned log lines to 100 when searching for "Ready." token (localstack#64) consider Windows EOL when listing images (localstack#65) release version 0.2.11 fix endpoint URL for getClientLambdaAsyncV2 (localstack#60) add simple tests for IAM service (localstack#62) read port config file in multiple locations for different Python versions in the container (localstack#59) Bump logback-classic from 1.0.13 to 1.2.0 (localstack#56) log which image is being pulled (localstack#58) Bump commons-io from 2.6 to 2.7 (localstack#53) add simple test for KMS (localstack#54) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fetched number of log lines (10) was too low s.t. when a container
took some time to boot the 404 messages from the request already took up
too much space in the logs, and the
Ready.token could not bedetected.
This commit increases the number of log lines to 100, so that this error
should be alleviated, although it is of course not an optimal solution.
It might make sense too simply fetch all logs (with a
-1parameter to--tail), andlet the user overwrite this value.
Closes #63