Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate files containing descriptions of AWS services #15

Merged
merged 14 commits into from
Apr 4, 2025

Conversation

k-a-il
Copy link
Contributor

@k-a-il k-a-il commented Mar 25, 2025

The goal of this PR is to add a reusable CI/CD pipeline to validate files containing descriptions of AWS services (aka. feature catalog files). This reusable workflow will be used in localstack/localstack and localstack/localstack-ext repositories as in this example.

What is part of this PR?
A CI/CD pipeline that performs the following tasks:

  • Check that features.yml file exists
  • Validate changed features.yml files against JSON schema

Example of testing done in a forked repo:

@k-a-il k-a-il changed the title Automation to validate newly created YAML files Validate files containing descriptions of AWS services Mar 25, 2025
@k-a-il k-a-il self-assigned this Mar 25, 2025
@k-a-il k-a-il requested a review from silv-io March 25, 2025 18:02
@k-a-il k-a-il marked this pull request as draft March 25, 2025 18:02
@k-a-il k-a-il marked this pull request as ready for review March 31, 2025 17:09
@k-a-il k-a-il requested a review from sannya-singal March 31, 2025 17:57
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some questions/suggestions :)

Copy link

@sannya-singal sannya-singal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for adding this 🚀 I have some comments and a question, rest LGTM.

@k-a-il k-a-il merged commit 34d8db0 into main Apr 4, 2025
@k-a-il k-a-il deleted the automation-features-files branch April 4, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants