Skip to content

Update .travis.yml to ajust to new release cadence #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Update .travis.yml to ajust to new release cadence #228

merged 2 commits into from
Nov 27, 2024

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Nov 14, 2024

No description provided.

This commit updates the travis matrix to use the updated release cadence.
@donoghuc
Copy link

Hmm looks like for 8.future we are missing this transformation:

#1 [logstash internal] load build definition from Dockerfile
#1 transferring dockerfile: 1.94kB done
#1 WARN: InvalidDefaultArgInFrom: Default value for ARG docker.elastic.co/logstash/logstash${DISTRIBUTION_SUFFIX}:${ELASTIC_STACK_VERSION} results in empty or invalid base image name (line 3)
#1 DONE 0.0s
#2 [logstash internal] load metadata for docker.elastic.co/logstash/logstash:8.future
#2 ERROR: docker.elastic.co/logstash/logstash:8.future: not found

https://github.com/logstash-plugins/.ci/blob/670ab81da4e9e6878fafaff72cf79df3bb8498e3/docker-setup.sh#L47-L57

@jsvd
Copy link
Member Author

jsvd commented Nov 25, 2024

allowing a 8.future stack version to not exist is not ideal but acceptable, so it should not block the build from being green: https://github.com/logstash-plugins/.ci/pull/68/files

@donoghuc
Copy link

Agree. Looks like that PR is merged. If you mark this as "ready for review" instead of "draft" will that trigger a fresh travis run? If we go green on that we should be g2g

@jsvd jsvd marked this pull request as ready for review November 25, 2024 15:59
@jsvd
Copy link
Member Author

jsvd commented Nov 25, 2024

I manually requested https://app.travis-ci.com/github/logstash-plugins/logstash-filter-geoip/builds/273267562, let's see..

@jsvd
Copy link
Member Author

jsvd commented Nov 27, 2024

@donoghuc I've simplified the travis.yml by only making it add the extra oss tests, leaving the default distribution tests to be read by the shared .ci definition. everything's green now.

@jsvd jsvd requested a review from donoghuc November 27, 2024 15:52
Copy link

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to the simplified layout.

@jsvd jsvd merged commit c2f432f into main Nov 27, 2024
3 checks passed
@jsvd jsvd deleted the jsvd-patch-1 branch November 27, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants