Skip to content

ecs: remove warning when using v8 #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ecs: remove warning when using v8 #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d6a7df
ecs: remove warning when using v8
yaauie Apr 4, 2025
e3ee180
Update CHANGELOG.md
yaauie Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 4.4.4
- Removed warning about ECS v8 being a preview [#195](https://github.com/logstash-plugins/logstash-filter-grok/pull/195)

## 4.4.3
- Minor typos in docs examples [#176](https://github.com/logstash-plugins/logstash-filter-grok/pull/176)

Expand Down
6 changes: 2 additions & 4 deletions lib/logstash/filters/grok.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,10 +330,8 @@ def patterns_path
case ecs_compatibility
when :disabled
patterns_path << LogStash::Patterns::Core.path # :legacy
when :v1
patterns_path << LogStash::Patterns::Core.path('ecs-v1')
when :v8
@logger.warn("ECS v8 support is a preview of the unreleased ECS v8, and uses the v1 patterns. When Version 8 of the Elastic Common Schema becomes available, this plugin will need to be updated")
when :v1, :v8
# v8 is an alias for v1; there were no relevant material changes to the schema
patterns_path << LogStash::Patterns::Core.path('ecs-v1')
else
fail(NotImplementedError, "ECS #{ecs_compatibility} is not supported by this plugin.")
Expand Down
2 changes: 1 addition & 1 deletion logstash-filter-grok.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Gem::Specification.new do |s|
s.name = 'logstash-filter-grok'
s.version = '4.4.3'
s.version = '4.4.4'
s.licenses = ['Apache License (2.0)']
s.summary = "Parses unstructured event data into fields"
s.description = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"
Expand Down
20 changes: 0 additions & 20 deletions spec/filters/grok_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,26 +774,6 @@ def self.sample(message, &block)

end

describe LogStash::Filters::Grok do

subject(:grok_filter) { described_class.new(config) }
let(:config) { {} }

context 'when initialized with `ecs_compatibility => v8`' do
let(:config) { super().merge("ecs_compatibility" => "v8", "match" => ["message", "%{SYSLOGLINE}"]) }
context '#register' do
let(:logger_stub) { double('Logger').as_null_object }
before(:each) { allow_any_instance_of(described_class).to receive(:logger).and_return(logger_stub)}

it 'logs a helpful warning about the unreleased v8' do
grok_filter.register

expect(logger_stub).to have_received(:warn).with(a_string_including "preview of the unreleased ECS v8")
end
end
end
end

describe LogStash::Filters::Grok do
describe "(LEGACY)" do
describe "patterns in the 'patterns/' dir override core patterns" do
Expand Down