Switch to 'runtimeClasspath' instead of resolve 'implementation' configuration #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iguration In PR logstash-plugins#69 the build.gradle was updated to run on Gradle 7, part of the change consisted in forcing the resolution of 'implementation' configuration to use it in the listing of dependencies. This could be assolved by the 'runtimeClasspath' without forcing the resolution which smells like a trick. Relates logstash-plugins#69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Switch to 'runtimeClasspath' instead of resolve 'implementation' configuration.
In PR #69 the build.gradle was updated to run on Gradle 7, part of the change consisted in
forcing the resolution of 'implementation' configuration to use it in the listing of dependencies.
This could be assolved by the 'runtimeClasspath' without forcing the resolution which smells like a trick.
Why is it important/What is the impact to the user?
Not directly impact the user
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration files (and/or docker env variables)I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
./gradlew clean vendoris ok, and required_jars.rb doesn't changeHow to test this PR locally
Related issues