Skip to content

Fix for Windows "unknown 0 0" identifier. #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2019
Merged

Fix for Windows "unknown 0 0" identifier. #233

merged 2 commits into from
Mar 12, 2019

Conversation

guyboertje
Copy link
Contributor

Make ruby string look like a C String.
Update travis LS target versions
Bump version to 4.1.10

Fixes #232

Fix for Windows "unknown 0 0" identifier.
c064e92 
Make ruby string look like a C String.
@elasticsearch-bot elasticsearch-bot self-assigned this Mar 7, 2019
yaauie
yaauie reviewed Mar 7, 2019
View reviewed changes
@guyboertje
Copy link
Contributor Author

@yaauie, Is this OK now?

@yaauie
Copy link
Contributor

yaauie commented Mar 12, 2019

LGTM

@guyboertje guyboertje merged commit 082897a into logstash-plugins:master Mar 12, 2019
@guyboertje guyboertje deleted the fix/232 branch July 17, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaauie yaauie yaauie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guyboertje @yaauie @elasticsearch-bot