discoverer.rb: Exclude patterns match filename #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation says: Exclusions (matched against the filename, not full path). Filename patterns are valid here, too. https://www.elastic.co/guide/en/logstash/current/plugins-inputs-file.html#plugins-inputs-file-exclude Fix can_exclude? method so it matches the filename and not the full pathname.
|
@logstash-core Here's a simple patch for a trivial regression in the logstash file input plugin. |
jsvd
reviewed
Jan 6, 2020
jsvd
approved these changes
Jan 6, 2020
|
@jsvd Done. |
|
Version 4.1.12 has been published! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#237
The documentation says: Exclusions (matched against the filename, not full path). Filename patterns are valid here, too.
Fix
can_exclude?method so it matches the filename and not the full pathname.