Bugfixed double conversion to seconds of sincedb_clean_after #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
reviewed
Feb 3, 2020
andsel
force-pushed
the
fix/sincedb_clean_after_double_conversion_to_secs
branch
from
90c17bd to
5e49fd8
Compare
|
The broken build seems to be related to ffi/ffi#743 because ffi-1.12.2-java gem is not published |
|
Andrea Selva merged this into the following branches!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #231 where the value of setting
sincedb_clean_afterresults to be multiplied by 24 * 3600 twice, so that 14 hours become 104509440000 second. It's due to the fact that after commit 28c0534 the old conversion method wasn't removed