Fix: release watched files on completion (in read-mode) #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
force-pushed
the
remove-watched-file-avoid-leak
branch
2 times, most recently
from
4bf6de5 to
9a0ca2b
Compare
kares
changed the title
andsel
reviewed
Apr 29, 2020
| end | ||
| @sort_method.call | ||
| removed_files |
There was a problem hiding this comment.
It's not clear to me why we the remove_paths returns the list of removed files. The method remove_paths is used inside the DeleteCompletedFileHandler.handle which on its own return the list of deleted files. That method is invoked by File.handle_deletable_path in an each loop and the method itself doesn't return nothing.
There was a problem hiding this comment.
Thanks Andrea, might have been a bit ahead of myself here ...
It's common for a (map) remove operation to return removed values.
The watched files collection is a ~ map ([String] path -> [WatchedFile] file), wanted to re-turn smt meaningful (planning to spec the return value with a collection rewrite to native).
kares
force-pushed
the
remove-watched-file-avoid-leak
branch
from
0cef200 to
59bb43e
Compare
kares
force-pushed
the
remove-watched-file-avoid-leak
branch
from
59bb43e to
309cdd8
Compare
not doing so leads to a steady increase in watched collection's size over time (esp. in use-cases where user is pulling in new files). the left-over file is never to be processed again - it's being deleted anyway using the completion handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not doing so leads to a steady increase in watched collection's size
over time (esp. in use-cases where user is pulling in new files).
the left-over watched file entry is never to be processed again - it's being deleted anyway (assuming
'file_completed_action' => "delete") using the completion handler.resolves #270
NOTE: please ignore the existing potential atomicity issues in the watched file collection a follow-up on this PR will deal with a
WatchedFileCollectionrewrite