Fix: avoid refering a SincedbValue when it's not present in SincedbCollection #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
reviewed
May 14, 2020
jsvd
approved these changes
May 14, 2020
…g flush If the value of the setting `sincedb_clean_after` is too short (1 ms) it happens that during the content reading loop (in read mode) the loops itself trigger the cleanup of the same value from the SincedbCollection and then it also try to access it again creating an error. This commit resolves the problem guarding against the presence in the sincebd_collection before accessing it. Fixes: logstash-plugins#272 Closes: logstash-plugins#273
andsel
force-pushed
the
fix/bug_during_startup_with_sincedb_Clean_after_too_small
branch
from
f68075d to
be18de7
Compare
|
Andrea Selva merged this to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the value of the setting
sincedb_clean_afteris too short (1 ms) it happens that during the content reading loop (in read mode) the loops itself trigger the cleanup of the same value from the SincedbCollection and then italso try to access it again creating an error.
This commit resolves the problem guarding against the presence in the sincebd_collection before accessing it.
Fixes: #272