[Test] Improve test flakiness #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbavey
force-pushed
the
fix_flaky_test
branch
4 times, most recently
from
d0ef72c to
89c7e20
Compare
robbavey
changed the title
cleans up sincedb entry
robbavey
force-pushed
the
fix_flaky_test
branch
5 times, most recently
from
e551e57 to
0eb4121
Compare
Add `ExpectationNotMetError` to the arguments to `Stud.try`. Without this, the retry logic does not trigger, leading to flakiness in this test as not enough time has elapsed for the sincedb entry to be cleaned up
This plugin suffers from a large amount of test flakiness in the travis ci environment. This commit continues the attempts to reduce this flakiness, starting with logstash-plugins#263 Mostly, this is increasing timeouts to deal with sluggish build servers, but also includes a fix to a Stud.try call which would not retry due to failure exceptions not matching.
robbavey
force-pushed
the
fix_flaky_test
branch
2 times, most recently
from
757e691 to
91c3e18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin suffers from a large amount of test flakiness in the travis
ci environment. This commit continues the attempts to reduce this flakiness,
starting with #263
Mostly, this is increasing timeouts to deal with sluggish build servers, but also
includes a fix to a Stud.try call which would not retry due to failure exceptions
not matching.