Doc: Set version attribute in plugin source file #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc:/ @mashhurs |
mashhurs
reviewed
Apr 18, 2022
docs/index.asciidoc
Outdated
| @@ -2,6 +2,11 @@ | |||
| :type: input | |||
| :default_codec: plain | |||
|
|
|||
| ifeval::["{versioned_docs}"=="true"] | |||
| :branch: %BRANCH% | |||
| :ecs_version: %BRANCH% | |||
There was a problem hiding this comment.
Shouldn't we set ECS version here? :ecs_version: %ECS_VERSION%?
karenzone
commented
Apr 20, 2022
This was referenced Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to plugin versioning work in elastic/docs-tools#70 and elastic/docs-tools#73.
The stack version attributes must be (calculated and) set on a per file basis, as the stack version will increment over time. I believe that this approach represents the right place to set those attributes.
Notes