Skip to content

support periodic manual commits #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsvd opened this issue May 14, 2018 · 3 comments
Open

support periodic manual commits #270

jsvd opened this issue May 14, 2018 · 3 comments

Comments

@jsvd
Copy link
Member

jsvd commented May 14, 2018

A manual periodic commit could be called manual_commit_interval_ms, where (if enable_auto_commit is false):

  • = 0 (default): commits on every poll
  • > 0: commits offsets at every interval (approximately)

This check would be done before the poll call (or after writing to the queue), so the interplay between poll_timeout_ms, fetch_max_wait_ms, request_timeout_ms and this new manual_commit_interval_ms would have to be sanity checked to ensure the users sets sane values.

for more context please see: #267 (comment)

@maverick298
Copy link

+1

1 similar comment
@DeeeFOX
Copy link

DeeeFOX commented Dec 17, 2019

+1

@DeeeFOX
Copy link

DeeeFOX commented Dec 17, 2019

amazing for this issue is still opening, and may last for years...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants