Exposing sasl.jaas.config setting #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbavey
requested changes
Apr 11, 2019
|
@vbohata Apologies for the delay - would you mind rebasing to the latest and resubmitting? This looks just about ready to go |
|
rebased |
|
@karenzone Would you mind giving this a look too? |
robbavey
approved these changes
Jul 11, 2019
|
@vbohata This is good to go - the build issues are an internal issue unrelated to your changes that I will subsequently fix. Once you give me the go ahead, I will merge this patch and publish it shortly afterwards, once I've fixed the CI issues Thank you for your contribution! |
|
Great, you can merge it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change which adds sasl_jaas_config allowing to set JAAS per plugin config instead of entire java process. Requested by for example here: #203 ...