Support routing option for documents #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -250,7 +254,7 @@ def register | |||
| client_settings["network.host"] = @bind_host if @bind_host | |||
| client_settings["transport.tcp.port"] = @bind_port if @bind_port | |||
| client_settings["client.transport.sniff"] = @sniffing | |||
|
|
|||
There was a problem hiding this comment.
your editor appears to have made a bunch of whitespace changes.
There was a problem hiding this comment.
Yeah, I noticed that too and was unhappy. Do I need to back them out? Should be easy to do.
|
Also, this was first requested back in JIRA and is finally implemented. Though, not specifically for space optimization as originally mentioned. |
|
Can you fix the unrelated whitespace changes? It's hard to read the diff and beyond that it will make |
The bulk API supports a specified `_routing` value for document placement within a shard in an index. This should be exposed for custom routing for aliases, filtering, etc. http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/docs-bulk.html#bulk-routing This also respects the move away from the routing parameter within the event as defined in: elastic/elasticsearch#6730
masteinhauser
force-pushed
the
es-routing
branch
from
b58934f to
9472bc4
Compare
|
Fixed! A much easier diff to review. |
|
Closing in support of #65 due to tests and more complete code. |
|
@masteinhauser thanks for your contribution! we'll fold your PR into #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk API supports a specified
_routingvalue for documentplacement within a shard in an index. This should be exposed for custom
routing for aliases, filtering, etc.
http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/docs-bulk.html#bulk-routing
This also respects the move away from the routing parameter within the
event as defined in:
elastic/elasticsearch#6730