Skip to content

[Doc] added the ILM pattern note #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2020
Merged

[Doc] added the ILM pattern note #971

merged 2 commits into from
Oct 6, 2020

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Oct 5, 2020

ILM pattern number part is 0-padded 6 digits wide string

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

@andsel andsel requested a review from karenzone October 5, 2020 12:21
@@ -523,6 +523,8 @@ NOTE: Updating the pattern will require the index template to be rewritten

NOTE: The pattern must finish with a dash and a number that will be automatically incremented when indices rollover.

NOTE: The patter number is a string zero-padded 6 digits wide, see {ref}/indices-rollover-index.html#rollover-index-api-path-params[Rollover path parameters API docs] for details

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*pattern

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pujithkurunji to point it out, fixed :-)

ILM pattern number part is 0-padded 6 digits wide string
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this important detail, @andsel. I left comments for a possible rewording in line.
Also this piece of information seems like an important part of the description and belong there instead of in a note.

@karenzone karenzone self-requested a review October 6, 2020 14:06
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this info

@andsel andsel merged commit b956d1c into master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants