fix: restrict python version and update cattrs version restriction #949

alekseiloginov · 2022-01-21T21:01:37Z

Description

We need to unpin cattrs version to avoid dependency conflicts with other tools using a later version of it.

cattrs version was pinned to 1.1.2 due to https://github.com/Tinche/cattrs/issues/119. Since the issue should be fixed in cattrs 1.3, we update the restriction to >=1.3.

Also python version need to be restricted to <=3.9.9 due to #944. Since Pipfile doesn't support qualifiers for python_full_version, it's set to 3.9.9.

github-actions · 2022-01-21T21:02:27Z

Typescript Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 7871264. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T21:02:28Z

APIX Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 7871264. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T21:02:31Z

Codegen Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 7871264. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T21:02:59Z

Python Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 7871264. ± Comparison against base commit ccde3cc.

python/setup.py

joeldodge79 · 2022-01-21T21:09:34Z

also, lets change the title to something like the following (to fit conventional commit msg standard)

fix: restrict python version and remove cattrs version

github-actions · 2022-01-21T21:14:48Z

Typescript Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit b170a64. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T21:14:51Z

Codegen Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit b170a64. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T21:14:51Z

APIX Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit b170a64. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T21:15:23Z

Python Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit b170a64. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T22:13:43Z

Typescript Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 7fce8d8. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T22:13:46Z

APIX Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 7fce8d8. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T22:13:47Z

Codegen Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 7fce8d8. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T22:15:30Z

Python Tests

    4 files +    4     4 suites +4 1s ⏱️ -1s
117 tests +117 117 ✔️ +117 0 💤 ±0 0 ❌ ±0
464 runs +464 464 ✔️ +464 0 💤 ±0 0 ❌ ±0

Results for commit 7fce8d8. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T22:21:31Z

APIX Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit aeb4f61. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T22:21:32Z

Codegen Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit aeb4f61. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T22:21:33Z

Typescript Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit aeb4f61. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-21T22:27:02Z

Python Tests

    8 files +    8     8 suites +8 1m 14s ⏱️ + 1m 14s
140 tests +140 139 ✔️ +139 0 💤 ±0 1 ❌ +1
742 runs +742 740 ✔️ +740 0 💤 ±0 2 ❌ +2

For more details on these failures, see this check.

Results for commit aeb4f61. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-22T00:00:58Z

Codegen Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 4ff147a. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-22T00:01:04Z

APIX Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 4ff147a. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-22T00:01:04Z

Typescript Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 4ff147a. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-22T00:08:13Z

Python Tests

  10 files +  10   10 suites +10 2m 53s ⏱️ + 2m 53s
140 tests +140 140 ✔️ +140 0 💤 ±0 0 ❌ ±0
788 runs +788 788 ✔️ +788 0 💤 ±0 0 ❌ ±0

Results for commit 4ff147a. ± Comparison against base commit ccde3cc.

github-actions · 2022-01-22T01:24:43Z

APIX Tests

0 files -     1 0 suites - 79 0s ⏱️ - 3m 15s
0 tests - 320 0 ✔️ - 307 0 💤 - 13 0 ❌ ±0
0 runs - 336 0 ✔️ - 323 0 💤 - 13 0 ❌ ±0

Results for commit 3120bfb. ± Comparison against base commit fa44a8a.

This pull request removes 320 tests.

 DocTitle renders a heading with title prop content ‑  DocTitle renders a heading with title prop content
 MethodBadge renders with the provided verb ‑  MethodBadge renders with the provided verb
ApiSpecSelector it fires a SELECT_SPEC action when another spec is selected ‑ ApiSpecSelector it fires a SELECT_SPEC action when another spec is selected
ApiSpecSelector it lists all available specs ‑ ApiSpecSelector it lists all available specs
ApiSpecSelector the default spec is selected by default ‑ ApiSpecSelector the default spec is selected by default
BrowserAdaptor returns correct font overrides ‑ BrowserAdaptor returns correct font overrides
CodeCopy displays code and clipboard UI ‑ CodeCopy displays code and clipboard UI
CodeDisplay it highlights text matching search pattern ‑ CodeDisplay it highlights text matching search pattern
CodeDisplay it syntax highlights ‑ CodeDisplay it syntax highlights
CodeDisplay utils it can syntax highlight all supported sdk langs ‑ CodeDisplay utils it can syntax highlight all supported sdk langs
…

github-actions · 2022-01-22T01:24:48Z

Typescript Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 3120bfb. ± Comparison against base commit fa44a8a.

github-actions · 2022-01-22T01:25:20Z

Codegen Tests

0 files ±0 0 suites ±0 0s ⏱️ ±0s
0 tests ±0 0 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 3120bfb. ± Comparison against base commit fa44a8a.

github-actions · 2022-01-22T01:35:06Z

Python Tests

  10 files +  10   10 suites +10 2m 55s ⏱️ + 2m 55s
140 tests +140 140 ✔️ +140 0 💤 ±0 0 ❌ ±0
788 runs +788 788 ✔️ +788 0 💤 ±0 0 ❌ ±0

Results for commit 3120bfb. ± Comparison against base commit fa44a8a.

jkaster

LGTM

potiuk · 2022-03-03T09:05:12Z

Just one comment here - pinning python version in a library is a very bad idea. What should people do if they already have python 3.9.10 installed ? This - for example - prevents apache/airflow#20882 from merging.

potiuk · 2022-03-03T09:15:07Z

The consequence of this change is that any other package that would be released with looker SDK released with this limitation will not be installable not only on Python 3.9.10 but also any other version it follows. This is extremely bad practice to upper-bound a Python version IMHO. I have never, ever seen a library doing it. It might be fine for an application if it has specific requirements and they are broken (because that application might simply be ok to refuse working on specific python version) but restricting an SDK/library to not being installable on a python version means that you are preventing any other packages that use looker SDK in this version from even installing on newer Python versions.

joeldodge79 · 2022-03-03T15:52:11Z

@potiuk you're correct, it's a less than ideal situation. We're working to resolve the issue but the choice is between pinning it ourselves or letting users find out that it's broken on 3.9.10+

The PR title should have reflected that this is a temporary measure to choose between the lesser of two evils while we find the resources to fix the actual issue

unpin cattrs version, restrict python to <=3.9.9

7871264

joeldodge79 suggested changes Jan 21, 2022

View reviewed changes

python/setup.py Show resolved Hide resolved

alekseiloginov changed the title ~~unpin cattrs version, restrict python to <=3.9.9~~ fix: restrict python version and remove cattrs version Jan 21, 2022

restrict cattrs to >= 1.3

b170a64

alekseiloginov changed the title ~~fix: restrict python version and remove cattrs version~~ fix: restrict python version and update cattrs version restriction Jan 21, 2022

fix: squash-me fixes

7fce8d8

ci: specify 3.9.9 for GHA

aeb4f61

This comment has been minimized.

Sign in to view

fix: seems like cattrs changed how enums are destructured

4ff147a

joeldodge79 force-pushed the unpin_cattrs_version branch from 3c12965 to 4ff147a Compare January 22, 2022 00:00

Merge branch 'main' into unpin_cattrs_version

3120bfb

jkaster approved these changes Jan 22, 2022

View reviewed changes

joeldodge79 self-requested a review January 22, 2022 02:30

joeldodge79 approved these changes Jan 22, 2022

View reviewed changes

joeldodge79 merged commit ba28ac6 into main Jan 22, 2022

joeldodge79 deleted the unpin_cattrs_version branch January 22, 2022 02:32

This comment has been minimized.

Sign in to view

jeremytchang mentioned this pull request Jan 25, 2022

looker-sdk 21.20.0 throws TypeError for python 3.9.10 #944

Closed

potiuk mentioned this pull request Mar 3, 2022

Add Looker PDT operators apache/airflow#20882

Merged

fix: restrict python version and update cattrs version restriction #949

fix: restrict python version and update cattrs version restriction #949

Conversation

alekseiloginov commented Jan 21, 2022 • edited Loading

Description

github-actions bot commented Jan 21, 2022

Typescript Tests

github-actions bot commented Jan 21, 2022

APIX Tests

github-actions bot commented Jan 21, 2022

Codegen Tests

github-actions bot commented Jan 21, 2022

Python Tests

joeldodge79 commented Jan 21, 2022

github-actions bot commented Jan 21, 2022

Typescript Tests

github-actions bot commented Jan 21, 2022

Codegen Tests

github-actions bot commented Jan 21, 2022

APIX Tests

github-actions bot commented Jan 21, 2022

Python Tests

github-actions bot commented Jan 21, 2022

Typescript Tests

github-actions bot commented Jan 21, 2022

APIX Tests

github-actions bot commented Jan 21, 2022

Codegen Tests

github-actions bot commented Jan 21, 2022

Python Tests

github-actions bot commented Jan 21, 2022

APIX Tests

github-actions bot commented Jan 21, 2022

Codegen Tests

github-actions bot commented Jan 21, 2022

Typescript Tests

github-actions bot commented Jan 21, 2022

Python Tests

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 22, 2022

Codegen Tests

github-actions bot commented Jan 22, 2022

APIX Tests

github-actions bot commented Jan 22, 2022

Typescript Tests

github-actions bot commented Jan 22, 2022

Python Tests

github-actions bot commented Jan 22, 2022

APIX Tests

github-actions bot commented Jan 22, 2022

Typescript Tests

github-actions bot commented Jan 22, 2022

Codegen Tests

github-actions bot commented Jan 22, 2022

Python Tests

jkaster left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

potiuk commented Mar 3, 2022

potiuk commented Mar 3, 2022

joeldodge79 commented Mar 3, 2022

alekseiloginov commented Jan 21, 2022 •

edited

Loading