chore: upgrade to [email protected]

[raymondfeng]

Blocked by typescript-eslint/typescript-eslint#815 (fixed by b21c2ce)
Worked around microsoft/TypeScript#34761

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

• npm test passes on your machine
• New tests added or existing tests modified to cover all changes
• Code conforms with the style guide
• API Documentation in code was updated
• Documentation in /docs/site was updated
• Affected artifact templates in packages/cli were updated
• Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

[dhmlau]

@raymondfeng , any reasons that we are renaming the *.datasource.json to *.config.json?

[raymondfeng]

any reasons that we are renaming the *.datasource.json to *.config.json?

It's a workaround/fix for microsoft/TypeScript#34761. Considering we have:

db.datasource.json
db.datasource.ts

TypeScript 3.7.x tries to emit db.datasource.d.ts for both files and complains about the conflict.

[marioestradarosa]

@raymondfeng nice catch on that. I read the whole issue on typescript and now I understand better. LGTM !.

I see conflicts of course with current applications in that they will need to manually change the datasource.json to datasource.config correct?.

Just a question: Isn't it possible to just move it to its own config directory ie: config/myds.datasource.json and put all the files there ?

[bajtos]

chore: refresh package-lock.json

Can we leave this change out of this pull request please and let RenovateBot do the job?

[bajtos]

The git history is not as clean as I would like it to be. Other than that, the patch LGTM.

[bajtos]

I am surprised to see this change as part of the commit chore: refresh package-lock.json, I would expect it to be a part of chore: upgrade to TypeScript 3.7.2.

[jomarocas]

Good day

i update typescript only for test error

first error is

error TS5056: Cannot write file '/dist/datasources/emptor.datasource.d.ts' because it would be overwritten by multiple input files.
error TS5056: Cannot write file '/dist/datasources/reactions.datasource.d.ts' because it would be overwritten by multiple input files.

Second error later of rename from reactions.datasource.ts to reactions.datasource.d.ts

500 Error: The key 'datasources.reactions' is not bound to any value in context application
 at ReactionsApplication.getBinding (/node_modules/@loopback/context/src/context.ts:889:11)

how can solve this?

[dhmlau]

@jomarocas, the naming convention for the datasource has been changed. Your problem should be fixed by renaming the datasource json files *.datasource.json to *.datasource.config.json.

For details, please see #4173 (comment).