Skip to content

Commit af2027b

Browse files
kimadelineluabud
authored andcommitted
Fix unit tests failing because of spaces in the Insiders workflow (microsoft#14306)
* Add .fileToCommandArgument() * Add custom workflow to test with spaces * Use toCommandArgument instead of fileToCommandArgument * Fix upload coverage step * $$$$$ * Delete test workflow * Update upload coverage step
1 parent 84a6719 commit af2027b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/insiders.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ jobs:
301301
uses: actions/upload-artifact@v1
302302
with:
303303
name: ${{runner.os}}-${{env.COVERAGE_REPORTS}}
304-
path: .nyc_output
304+
path: ${{ env.special-working-directory }}/.nyc_output
305305
if: matrix.test-suite == 'ts-unit' && startsWith(matrix.python, 3.)
306306

307307
# Run the Python and IPython tests in our codebase.

src/test/interpreters/activation/service.unit.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ suite('Interpreters Activation - Python Environment Variables', () => {
146146
const expectedCommand = [
147147
...cmd,
148148
`echo '${getEnvironmentPrefix}'`,
149-
`python ${isolated} ${printEnvPyFile.fileToCommandArgument()}`
149+
`python ${isolated.toCommandArgument()} ${printEnvPyFile.fileToCommandArgument()}`
150150
].join(' && ');
151151

152152
expect(shellCmd).to.equal(expectedCommand);

0 commit comments

Comments
 (0)