Fix unit tests failing because of spaces in the Insiders workflow #14306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
approved these changes
Oct 7, 2020
|
Closing and reopening because I opened this PR during the cursed time frame, and no status checks were reported. |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #14306 +/- ##
==========================================
- Coverage 59.91% 59.89% -0.03%
==========================================
Files 709 709
Lines 39334 39334
Branches 5698 5698
==========================================
- Hits 23567 23558 -9
- Misses 14529 14535 +6
- Partials 1238 1241 +3
Continue to review full report at Codecov.
|
luabud
pushed a commit
to luabud/vscode-python
that referenced
this pull request
Oct 26, 2020
…crosoft#14306) * Add .fileToCommandArgument() * Add custom workflow to test with spaces * Use toCommandArgument instead of fileToCommandArgument * Fix upload coverage step * $$$$$ * Delete test workflow * Update upload coverage step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #14294
Had to fix the coverage upload step as well.
See https://github.com/kimadeline/vscode-python/actions/runs/294134434:
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).