Pretty print using prettier #25

mohsen1 · 2018-01-20T20:56:04Z

Fixes #18

TODO:

Update tests with pretty printed output
Detect single quote vs double quote from source file and use it for prettier
Detect indentation from source file and use it for prettier
Detect code width from source file and use it for prettier
Detect semi from source file and use to for prettier option (not sure if possible)
CLI accept all prettier options and proxy it to prettier

mohsen1 · 2018-01-21T01:20:51Z

test/collapse-intersection-interfaces-transform/simple/output.tsx

@@ -1,4 +1,4 @@
 type Foo = {
-    foo: string;
-    bar: number;
+foo: string,


Why no indent?!

mohsen1 · 2018-01-21T01:21:14Z

test/end-to-end/non-react/output.tsx

@@ -1,9 +1,8 @@
 class Foo {
    render() {
-        return '100';
+        return '100'


semi should be on by default. this is a bug

mohsen1 · 2018-01-21T01:22:10Z

test/react-stateless-function-make-props-transform/stateless-function/output.tsx

@@ -1,9 +1,9 @@
 type HelloProps = {
-    message?: string;
+	message?: string


vincentbel · 2018-01-21T02:47:25Z

@mohsen1 I think we can resolve prettier config by default by using prettier.resolveConfig. And also support setting prettier config in CLI.

mohsen1 · 2018-01-21T03:59:31Z

Beautiful! I didn't notice that api

mohsen1 commented Jan 21, 2018

View reviewed changes

Pretty print using prettier

0ef45c4

mohsen1 force-pushed the pass-prettier branch from 0e52452 to 0ef45c4 Compare January 21, 2018 18:58

mohsen1 added 3 commits January 21, 2018 11:00

Remove yarn log

fc129a7

Use CLI input for prettier config

0be7af7

pass config in test

a2cd0d3

mohsen1 merged commit 95f308b into master Jan 21, 2018

mohsen1 deleted the pass-prettier branch January 21, 2018 19:26