Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server-side support #32

Closed
aspiers opened this issue Dec 12, 2016 · 4 comments
Closed

server-side support #32

aspiers opened this issue Dec 12, 2016 · 4 comments

Comments

@aspiers
Copy link

aspiers commented Dec 12, 2016

It's great having client-side validation, but let's face it some developers will simply forget or be too lazy to set it up, and then they'll submit bad commits for review regardless. So ideally there should be a way to enforce validation server-side. Of course the implementation depends on the server in question, but GitHub might be a good place to start. For example might it be possible to create a GitHub third-party service which runs fit-commit server-side whenever a PR is submitted / updated, and then updates a status check on the PR accordingly?

See also codeclimate/spec#45 (allow analysis of commit messages)

@aspiers
Copy link
Author

aspiers commented Dec 13, 2016

OK, this was basically a stupid question as per jorisroovers/gitlint#19 (comment) - closing :)

@aspiers aspiers closed this as completed Dec 13, 2016
@m1foley
Copy link
Owner

m1foley commented Dec 13, 2016

Not a stupid question. I'm considering documenting how to run it standalone for use cases like this.

I'd probably do this with a simple shell script on the CI machine. It exits with an error code if any errors are present which should fail the CI build.

$ GIT_BRANCH_NAME=master COMMIT_MESSAGE_PATH=path/to/message rbenv exec ruby -rrubygems -e 'require "fit_commit"; FitCommit.run'

m1foley pushed a commit that referenced this issue Dec 13, 2016
m1foley pushed a commit that referenced this issue Dec 13, 2016
@aspiers
Copy link
Author

aspiers commented Dec 13, 2016

Oh yeah, good idea to document this - thanks! Of course feel free to reopen if you want to track that task :)

@m1foley m1foley reopened this Dec 13, 2016
@m1foley
Copy link
Owner

m1foley commented Dec 13, 2016

Documentation added.

@m1foley m1foley closed this as completed Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants