Skip to content

version numbers is snapshot 162 broken #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
core-code opened this issue Mar 3, 2020 · 3 comments · Fixed by #1016
Closed

version numbers is snapshot 162 broken #1011

core-code opened this issue Mar 3, 2020 · 3 comments · Fixed by #1016
Milestone
snapshot-163

Comments

@core-code
Copy link

the version number in snapshot 162 is broken. this is a regression from snapshot 161

Screenshot 2020-03-03 at 17 05 25

Screenshot 2020-03-03 at 17 05 21

specifically the CFBundleShortVersionString in your Info.plist file is set to '.'

it should probably be set to '162' or '8.2.319' instead. in the previous release is was set to '8.1.2234
@ychin
Copy link
Member

ychin commented Mar 3, 2020 •
edited
Loading

Yes this is a bug in the configuration code. Will be fixed in next version.

@ychin ychin added this to the snapshot-163 milestone Mar 3, 2020
@core-code
Copy link
Author

awesome, thanks!

@eirnym
Copy link
Contributor

eirnym commented Mar 3, 2020

as well it was said in Sparkle, that it was a 8.3.319 instead of 8.2.319

ychin added a commit to ychin/macvim that referenced this issue Mar 9, 2020
@ychin
Fix configure not parsing Vim version correctly
9635255 
Fix the script to parse Vim version correct as version.h had a refactor.
Also, make sure if the output version string doesn't look right, we will
fail the configure script so we know something is wrong after merging
from Vim upstream.

Fix macvim-dev#1011
@ychin ychin mentioned this issue Mar 9, 2020
Merged
ychin added a commit to ychin/macvim that referenced this issue Apr 11, 2020
@ychin
MacVim Snapshot 163
184a120 
Vim patch 8.2.539

General:

- MacVim now reports its app category to be "Productivity" for Screen
  Time. macvim-dev#1032

Fixes:

- Fix MacVim not reporting its version number correctly. macvim-dev#1011
- Fix mvim:// protocol handler not handling line number. macvim-dev#1020
- Fix opening MacVim from the Dock not setting UTF.8 in locale. macvim-dev#1033
- Buffer menu now doesn't show stale menu items from command-line
  windows or terminal windows. macvim-dev#1025

Targets macOS 10.9+

Script interfaces have compatibility with these versions:
TODO
- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.7
@ychin ychin mentioned this issue Apr 12, 2020
Closed
ychin added a commit that referenced this issue Apr 12, 2020
@ychin
MacVim Snapshot 163
2b9a6a1 
Vim patch 8.2.539

General:

- MacVim now reports its app category to be "Productivity" for Screen
  Time. #1032

Fixes:

- Fix MacVim not reporting its version number correctly. #1011
- Fix mvim:// protocol handler not handling line number. #1020
- Fix opening MacVim from the Dock not setting UTF-8 in locale. #1033
- Buffer menu now doesn't show stale menu items from command-line
  windows or terminal windows. #1025

Targets macOS 10.9+

Script interfaces have compatibility with these versions:
- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
snapshot-163
Development

Successfully merging a pull request may close this issue.

Fix configure not parsing Vim version correctly ychin/macvim
3 participants
@eirnym @ychin @core-code