Skip to content

MacVim silently fails to save a file when a conversion error is present #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dschuessler opened this issue Apr 12, 2018 · 6 comments
Closed

MacVim silently fails to save a file when a conversion error is present #671

dschuessler opened this issue Apr 12, 2018 · 6 comments
Milestone
snapshot-156

Comments

@dschuessler
Copy link

Steps to reproduce:

  1. Create a text file that yields a CONVERSION ERROR when saved in Vim (e.g. when trying to save it with :w).
  2. Try to close the corresponding MacVim window (e.g. by clicking on the red wine gum).
  3. When the dialogue appears, that asks if you want to save the file, confirm.

Expected behavior: I get some alert that the file did not actually save and why.

Actual behavior: The dialogue, that asks if you want to save the file, disappears and the window simply does not close.
@jpetrie
Copy link
Contributor

jpetrie commented Jul 30, 2018

Do you have an example of such a file or information about how we could create one from scratch?

@dschuessler
Copy link
Author

dschuessler commented Aug 31, 2018 •
edited
Loading

  1. Open an empty buffer.
  2. :set fileencoding=latin1
  3. Write an Emoji into the buffer.
  4. Try to save as described above.

@eirnym eirnym mentioned this issue May 18, 2019
Closed
@eirnym
Copy link
Contributor

eirnym commented May 18, 2019

@dschuessler I reproduced the issue in terminal Vim and filled the issue to the upstream. Please, follow up there.

@eirnym
Copy link
Contributor

eirnym commented May 18, 2019

@ychin the underlying issue was fixed in vim-patch:8.1.1349. Please update the base

@ychin
Copy link
Member

ychin commented May 19, 2019

Will do. Thanks. Will close this issue after I release a new MacVim update.

@ychin ychin added this to the snapshot-156 milestone May 19, 2019
ychin added a commit to ychin/macvim that referenced this issue Jun 11, 2019
@ychin
MacVim Snapshot 156
d354527 
Vim patch 8.1.1517

Security Fixes:

- Fix modeline security vulnerability (CVE-2019-12735). macvim-dev#898 (fixed in
  Vim 8.1.265)

Features:

- Add new option 'MMTitlebarAppearsTransparent' that will make the title
  bar transparent and use the background color in the color scheme
  (10.14 or above only). macvim-dev#888

Fixes:

- Fix filename parsing error when opening a file with special characters
  like '$' in file path. macvim-dev#863
- Fix blurry I-beam mouse cursor. macvim-dev#755
- Fix silently failing to save a file when conversion error is present.
  macvim-dev#671. (Vim 8.1.1349)
- Fix failing to save to a network shared SMB folder macvim-dev#861.
  (Vim 8.1.0957)

Misc:

- 'guitablabel' can now be set in .vimrc, without MacVim overriding it.
  macvim-dev#899

Targets macOS 10.8+

Script interfaces have compatibility with these versions:

- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.6
@ychin
Copy link
Member

ychin commented Jun 11, 2019

Released a new update. Closing.

@ychin ychin closed this as completed Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
snapshot-156
Development

No branches or pull requests
4 participants
@eirnym @ychin @jpetrie @dschuessler