Tabs do not pick dark theme on Mojave #775
Comments
|
Are you building MacVim locally or using HomeBrew? Right now Mojave doesn't work very well due to #751 and you should see a lot of flickering when you use MacVim built for Mojave. Currently focus is on fixing that first, but I will look into the tab issues. |
|
I use Homebrew binary. I know about #751. I have Core Text Renderer disabled. It works (doesn't flicker) apart from minor space width issues on otherwise blank lines. |
|
Is there a work around for this until #751 is resolved? |
|
@bhargavshivkumar You could do one of the following:
Edit: Also, this issue is unrelated to #751 so even if that issue is resolved this issue would still persist. |
|
@ychin When you say use the snapshot version i'm assuming you are saying i should install using the dmg file instead of using homebrew binaries? (sorry relatively new to the Mac way of things) |
|
@bhargavshivkumar Yes I meant installing the prebuilt dmg file from Github releases (we just call them snapshots). The latest one (151) should be fine and is built against High Sierra. I plan to merge in all Mojave support soon so Homebrew builds won't stay broken. There should be a corresponding snapshot-152 release as well and it would be built against Mojave. |
Add a new tab style "Mojave". The files were copied from Yosemite-style tabs but with additional improvements. It now reads the colors from an asset catalog with colors for both dark and light modes. The colors and style are also retuned to look more like native Mojave tabs. Reason for cloning PSMYosemiteTabStyle is to avoid having too many special cases in a single file and to avoid breaking its behaviors on older systems. Also, PSMTabBarControl is mostly a dead project, so it's wise to modify existing code as little as possible. MacVim will only use this style if it's compiled with Mojave SDKs and it's actually being run in Mojave (10.14) or higher. Fix macvim-dev#775
Add a new tab style "Mojave". The files were copied from Yosemite-style tabs but with additional improvements. It now reads the colors from an asset catalog with colors for both dark and light modes. The colors and style are also retuned to look more like native Mojave tabs. The new tab and close tab buttons are now using a style much more similar to what native macOS are like, with the close tab button showing up when mouse is hovering over a particular tab. Reason for cloning PSMYosemiteTabStyle is to avoid having too many special cases in a single file and to avoid breaking its behaviors on older systems. Also, PSMTabBarControl is mostly a dead project, so it's wise to modify existing code as little as possible. MacVim will only use this style if it's compiled with Mojave SDKs and it's actually being run in Mojave (10.14) or higher. Fix macvim-dev#775
Add a new tab style "Mojave". The files were copied from Yosemite-style tabs but with additional improvements. It now reads the colors from an asset catalog with colors for both dark and light modes. The colors and style are also retuned to look more like native Mojave tabs. The new tab and close tab buttons are now using a style much more similar to what native macOS are like, with the close tab button showing up when mouse is hovering over a particular tab. Reason for cloning PSMYosemiteTabStyle is to avoid having too many special cases in a single file and to avoid breaking its behaviors on older systems. Also, PSMTabBarControl is mostly a dead project, so it's wise to modify existing code as little as possible. MacVim will only use this style if it's compiled with Mojave SDKs and it's actually being run in Mojave (10.14) or higher. Fix macvim-dev#775
Add a new tab style "Mojave". The files were copied from Yosemite-style tabs but with additional improvements. It now reads the colors from an asset catalog with colors for both dark and light modes. The colors and style are also retuned to look more like native Mojave tabs. The new tab and close tab buttons are now using a style much more similar to what native macOS are like, with the close tab button showing up when mouse is hovering over a particular tab. Reason for cloning PSMYosemiteTabStyle is to avoid having too many special cases in a single file and to avoid breaking its behaviors on older systems. Also, PSMTabBarControl is mostly a dead project, so it's wise to modify existing code as little as possible. MacVim will only use this style if it's compiled with Mojave SDKs and it's actually being run in Mojave (10.14) or higher. Fix macvim-dev#775
Tabs do not fully pick up dark theme in Mojave. Only text changes color. This results in a really low-contrast look. It wouldn't be much issue if it didn't change text color but currently it make it hard to use MacVim tabs with dark theme.
This is most probably related to #544.
The text was updated successfully, but these errors were encountered: