Ctrl-C when in command-line mode doesn't work anymore #846

ychin · 2019-02-05T01:01:58Z

Seems like snapshot 154 broke this functionality. Pressing Ctrl-C in command-line mode doesn't break out of it anymore, but a follow-on key press would.

ychin · 2019-02-05T02:54:06Z

Seems like e40b9d4 (v8.1.0834) broke this. It could either be a bug in Vim or a merge error on MacVim's side.

segeljakt · 2019-02-05T20:21:25Z

Also, remapping cnoremap <C-c> <Esc> does not work. :/

mathsaey · 2019-02-12T22:05:35Z

I'm facing the same issue. Pressing ctrl-c in any mode causes a spike in CPU usage and a noticeable delay. The issue only seems to occur in when using the MacVim gui. (so it doesn't seem to be an issue on the vim side).

ychin · 2019-02-13T02:08:32Z

I'm still looking into this, but the CPU usage bit is interesting info. Just for context MacVim relies on the GUI codebase in Vim itself and basically works as a special type of gVim. That's why when Vim's GUI code goes through refactor like this, sometimes bugs creep in despite a clean merge since we have to re-do some of the changes downstream to match the upstream changes.

Vim has a "ctrl_c_interrupts" mode that gets turned on in misc modes (e.g. Normal / Command-Line mode) when <C-C> is not mapped. In this mode, Ctrl-C has special behavior and is hard-coded (i.e. not remappable). There is an old bug in how MacVim handles Ctrl-C under this mode. It's trying to be smart and aggressively clears the input queue (even non-text-related ones) without adding anything to the input queue. Previously it kind of worked due to a coincidence in how Vim's GUI handled input logic, but it was fragile. The recent Vim refactor that changed Vim GUI's input handling broke this. Instead, don't do any of these smart input queue clearing and just do what other Vim GUI code does and call `trash_input_buf()`, set `set_int`, and then add the Ctrl-C to the input queue. MacVim still has `Cmd-.` for an aggressive interrupt in case Vim is hung (which shouldn't happen to begin with). Fix macvim-dev#846

Vim has a "ctrl_c_interrupts" mode that gets turned on in misc modes (e.g. Normal / Command-Line mode) when <C-C> is not mapped. In this mode, Ctrl-C has special behavior and is hard-coded (i.e. not remappable). There is an old bug in how MacVim handles Ctrl-C under this mode. It's trying to be smart and aggressively clears the input queue (even non-text-related ones) without adding anything to the input queue. Previously it kind of worked due to a coincidence in how Vim's GUI handled input logic, but it was fragile. The recent Vim refactor that changed Vim GUI's input handling broke this. Instead, don't do any of these smart input queue clearing and just do what Vim GUI code in other platforms does and call `trash_input_buf()`, set `set_int`, and then add the Ctrl-C to the input queue. MacVim still has `Cmd-.` for an aggressive interrupt in case Vim is hung (which shouldn't happen to begin with). Fix macvim-dev#846

ychin added this to the snapshot-155 milestone Feb 5, 2019

ychin mentioned this issue Feb 18, 2019

Fix MacVim Ctrl-C handling in Normal and Command-Line modes #856

Merged

ychin closed this as completed in #856 Feb 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ctrl-C when in command-line mode doesn't work anymore #846

Ctrl-C when in command-line mode doesn't work anymore #846

ychin commented Feb 5, 2019

ychin commented Feb 5, 2019 •

edited

Loading

segeljakt commented Feb 5, 2019

mathsaey commented Feb 12, 2019

ychin commented Feb 13, 2019 •

edited

Loading

Ctrl-C when in command-line mode doesn't work anymore #846

Ctrl-C when in command-line mode doesn't work anymore #846

Comments

ychin commented Feb 5, 2019

ychin commented Feb 5, 2019 • edited Loading

segeljakt commented Feb 5, 2019

mathsaey commented Feb 12, 2019

ychin commented Feb 13, 2019 • edited Loading

ychin commented Feb 5, 2019 •

edited

Loading

ychin commented Feb 13, 2019 •

edited

Loading