Rows of text seem clipped at certain font sizes on Catalina #905

twk · 2019-06-11T00:14:35Z

Running 8.1.950 on Catalina, when I start MacVim, some lowercase letters are getting clipped:

If I adjust the font size and then adjust it back, things are rendered correctly:

This started as soon as I upgraded to Catalina -- Mojave was fine. My font settings are English/Menlo/Regular/11

ychin · 2019-06-11T06:25:20Z

I will need to see if I can repro this under the new Xcode. Otherwise could be tricky as I don't have a beta Catalina install with me.

adamjacobmuller · 2019-06-14T01:52:02Z

Happens for me after upgrading to catalina, but, only with Core Text renderer enabled.

With Core Text renderer disabled things are actually considerably worse.

actual:

eirnym · 2019-06-14T20:11:37Z

I'd wait for first public beta. Before that point macOS is not really usable at all

adamjacobmuller · 2019-06-14T21:06:38Z

Aside from the MacVim issue my workflow is fine and I've just been running vim instead.

eirnym · 2019-06-15T01:40:32Z

I'm really surprised to read it! This release will be the first one with relatively stable betas, since it wasn't a case since macOS 10.7 Beta 1

eirnym · 2019-06-26T16:45:07Z

Public Beta is out…

eirnym · 2019-06-26T22:30:55Z

It's interesting, I can reproduce it with

guifont=Menlo-Regular:h11, but not with guifont=Fira\ Code\ Light:h12

jjgod · 2019-07-28T16:58:09Z

This is a duplicate of #883.

jjgod · 2019-07-28T17:08:54Z

Oh, @eirnym, it's because the comparison sees that the new font Menlo-Regular:h11 is the same as the default font initialized by -[MMCoreTextView initWithFrame:] and skip rest of the initialization:

if (!(newFont && font != newFont))
    return;

That's why in this case fontDescent is still properly initialized.

jjgod · 2019-07-28T17:09:34Z

(lldb) p font
(NSCTFont *) $0 = 0x0000000101c233e0
(lldb) p newFont
(NSCTFont *) $1 = 0x0000000101c233e0
(lldb) po font
"Menlo-Regular 11.00 pt. P [] (0x101c28300) fobj=0x101c233e0, spc=6.62"

(lldb) po newFont
"Menlo-Regular 11.00 pt. P [] (0x101a00860) fobj=0x101c233e0, spc=6.62"

eirnym · 2019-07-28T19:48:34Z

I've tried it after Fira Code, to guarantee that it's a different one

jjgod · 2019-07-28T20:02:30Z

That's why you are not hitting the problem with Fira Code.

eirnym · 2019-07-28T20:32:30Z

and what's about Menlo?

I've set Fira Code first, then Menlo, and issue still exists. This doesn't neglect your issue on fontDescent, though. Probably, in macOS Catalina this parameter becomes more valuable to set if it's not.

jjgod · 2019-07-28T23:41:27Z

How exactly did you do that? Did you execute multiple set guifont command?

ychin · 2019-07-29T17:14:08Z

I think this should now be fixed and will be released in the next update. If someone wants to confirm (I haven't installed the beta macOS yet) that would be great.

eirnym · 2019-07-30T05:28:47Z

I'll test it today

adamjacobmuller · 2019-09-24T19:36:46Z

i'm happy to test but i don't particularly want to build this myself and it seems like the last release was 157, any chance of 158 being released to test?

tobireif · 2019-10-08T14:12:54Z

I just installed MacOS Catalina (version "10.15 (19A583)"). Now I get this issue:

The test-text: Qq Gg Yy
MacVim version "Custom Version 8.1.1722 (157)".
This is a severe issue. I hope it can get fixed soon.
:set guifont? says Menlo.

securitygeneration · 2019-10-09T09:21:04Z

I'm also surprised this wasn't fixed/released prior to Catalina's release.

eirnym · 2019-10-09T12:03:12Z

@securitygeneration This is an open source project. You could do a contribution of your time and knowledge.

securitygeneration · 2019-10-09T12:18:08Z

@eirnym I was following this and saw that it seemed to be tentatively resolved (#905 (comment)), and so it didn't seem to need any additional attention (although yes, I could've tried to test it). ¯\_(ツ)_/¯

ychin · 2019-10-10T10:42:51Z

Next update will be out this weekend.

hoke-t · 2019-10-14T17:18:06Z

Any updates on this?

isaki · 2019-10-14T21:12:57Z

As per @eirnym, I am posting this here and closing my issue.

I can confirm this is still an issue after the weekend.

I am running the latest release:

And can confirm fonts still look strange:

And that the changing the font size back and forth fixes things:

My macOS version:

% sw_vers 
ProductName:	Mac OS X
ProductVersion:	10.15
BuildVersion:	19A583

eirnym · 2019-10-15T07:59:40Z

@isaki Thank you for an addition, Please, write which distribution of MacVim do you use (e.g. GitHub, Homebrew, MacPorts, etc) and which font are you using (:set guifont?)

tobireif · 2019-10-15T10:43:52Z

changing the font size back and forth fixes things

Here it fixes it temporarily for that one buffer/window, but not permanently.

(I'm using the distribution from https://github.com/macvim-dev/macvim/releases plus auto-updates.)

:set guifont? says guifont=Menlo:h16

hoke-t · 2019-10-15T14:57:08Z

I have the exact issue as well. I always have to increase and then decrease the font size upon opening a file to fix the clipping.

Using macOS 10.15 build version 19A583, Homebrew distribution of MacVim, and set guifont? gives guifont=Menlo-Regular:h11.

isaki · 2019-10-15T15:10:31Z

@eirnym I am using the GitHub distribution of MacVim.

I apparently have no font set once so ever:

Also, commands are also being chopped off:

Finally, this is the font setup that seems to be in use when I run set guifont=*:

I hope this information helps!

eirnym · 2019-10-15T18:35:37Z

Thank you, this is fixed in HEAD. So I hope @ychin will find the time to prepare a release.

jimsiff · 2019-10-17T02:22:33Z

Thank you @eirnym and @ychin. It's fixed for me after building 8.1.2102 on Catalina.

Vim patch 8.1.2102 Features: - Can now use autocommand to detect an OS appearance change (dark vs light mode). See `:help OSAppearanceChanged`. macvim-dev#766 Fixes: - Fix text being clipped in macOS Catalina. macvim-dev#905 Targets macOS 10.8+ Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.7 - Ruby 2.6

Vim patch 8.1.2168 Features: - Can now use autocommand to detect an OS appearance change (dark vs light mode). See `:help OSAppearanceChanged`. #766 Fixes: - Fix text being clipped in macOS Catalina. #905 - Fix "E432: Tags file not sorted" issue in macOS Catalina. #953. (Vim 8.1.2152) Targets macOS 10.8+ Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.7 - Ruby 2.6

ychin · 2019-10-17T09:54:45Z

This should be fixed in snapshot-159. Let me know if it isn't.

isaki · 2019-10-17T18:13:03Z

This has indeed fixed it, thank you!

hoke-t · 2019-10-17T20:52:59Z

Can confirm as well. Thanks!

ychin added the 10.15 Catalina label Jun 11, 2019

ychin added this to the snapshot-158 milestone Jul 29, 2019

eirnym mentioned this issue Oct 9, 2019

Upgraded to Mac OS 10.15, the string is truncated #951

Closed

isaki mentioned this issue Oct 14, 2019

Graphical rendering issue on 10.15 (Catalina) #955

Closed

eirnym mentioned this issue Oct 15, 2019

MacVim + Catalina Font issues #949

Closed

ychin closed this as completed Oct 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rows of text seem clipped at certain font sizes on Catalina #905

Rows of text seem clipped at certain font sizes on Catalina #905

twk commented Jun 11, 2019

ychin commented Jun 11, 2019

adamjacobmuller commented Jun 14, 2019 •

edited

Loading

eirnym commented Jun 14, 2019

adamjacobmuller commented Jun 14, 2019

eirnym commented Jun 15, 2019

eirnym commented Jun 26, 2019

eirnym commented Jun 26, 2019 •

edited

Loading

jjgod commented Jul 28, 2019

jjgod commented Jul 28, 2019

jjgod commented Jul 28, 2019

eirnym commented Jul 28, 2019

jjgod commented Jul 28, 2019

eirnym commented Jul 28, 2019

jjgod commented Jul 28, 2019

ychin commented Jul 29, 2019

eirnym commented Jul 30, 2019

adamjacobmuller commented Sep 24, 2019

tobireif commented Oct 8, 2019 •

edited

Loading

securitygeneration commented Oct 9, 2019

eirnym commented Oct 9, 2019

securitygeneration commented Oct 9, 2019 •

edited

Loading

ychin commented Oct 10, 2019

hoke-t commented Oct 14, 2019

isaki commented Oct 14, 2019

eirnym commented Oct 15, 2019 •

edited

Loading

tobireif commented Oct 15, 2019

hoke-t commented Oct 15, 2019

isaki commented Oct 15, 2019

eirnym commented Oct 15, 2019

jimsiff commented Oct 17, 2019

ychin commented Oct 17, 2019

isaki commented Oct 17, 2019

hoke-t commented Oct 17, 2019

Rows of text seem clipped at certain font sizes on Catalina #905

Rows of text seem clipped at certain font sizes on Catalina #905

Comments

twk commented Jun 11, 2019

ychin commented Jun 11, 2019

adamjacobmuller commented Jun 14, 2019 • edited Loading

eirnym commented Jun 14, 2019

adamjacobmuller commented Jun 14, 2019

eirnym commented Jun 15, 2019

eirnym commented Jun 26, 2019

eirnym commented Jun 26, 2019 • edited Loading

jjgod commented Jul 28, 2019

jjgod commented Jul 28, 2019

jjgod commented Jul 28, 2019

eirnym commented Jul 28, 2019

jjgod commented Jul 28, 2019

eirnym commented Jul 28, 2019

jjgod commented Jul 28, 2019

ychin commented Jul 29, 2019

eirnym commented Jul 30, 2019

adamjacobmuller commented Sep 24, 2019

tobireif commented Oct 8, 2019 • edited Loading

securitygeneration commented Oct 9, 2019

eirnym commented Oct 9, 2019

securitygeneration commented Oct 9, 2019 • edited Loading

ychin commented Oct 10, 2019

hoke-t commented Oct 14, 2019

isaki commented Oct 14, 2019

eirnym commented Oct 15, 2019 • edited Loading

tobireif commented Oct 15, 2019

hoke-t commented Oct 15, 2019

isaki commented Oct 15, 2019

eirnym commented Oct 15, 2019

jimsiff commented Oct 17, 2019

ychin commented Oct 17, 2019

isaki commented Oct 17, 2019

hoke-t commented Oct 17, 2019

adamjacobmuller commented Jun 14, 2019 •

edited

Loading

eirnym commented Jun 26, 2019 •

edited

Loading

tobireif commented Oct 8, 2019 •

edited

Loading

securitygeneration commented Oct 9, 2019 •

edited

Loading

eirnym commented Oct 15, 2019 •

edited

Loading