Skip to content

Expose more options in an appearance preference tab #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ychin opened this issue Jun 17, 2019 · 0 comments · Fixed by #1038
Closed

Expose more options in an appearance preference tab #912

ychin opened this issue Jun 17, 2019 · 0 comments · Fixed by #1038
Milestone

Comments

@ychin
Copy link
Member

ychin commented Jun 17, 2019

Expose more options such as the newly added MMTitlebarAppearsTransparent (#888) in Preferences (probably a new "Appearance" pane). These options are useful enough and easy to understand so it may make sense to expose them in the UI rather than only settable in terminal.

@ychin ychin added this to the snapshot-157 milestone Jun 17, 2019
@ychin ychin modified the milestones: snapshot-157, snapshot-158 Jul 17, 2019
@ychin ychin modified the milestones: snapshot-158, snapshot-159 Oct 16, 2019
@ychin ychin modified the milestones: snapshot-160, snapshot-161 Oct 26, 2019
@ychin ychin modified the milestones: snapshot-162, snapshot-163 Mar 3, 2020
@ychin ychin modified the milestones: snapshot-163, Backlog Apr 11, 2020
ychin added a commit to ychin/macvim that referenced this issue Apr 13, 2020
Add new preference that allows specifying how MacVim will use dark mode:
use systems preference (default), force light mode, force dark mode, or
use Vim's 'background' option to decide. Preference will be stored in
defaults as 'MMAppearanceModeSelection'. Add docs for that as well.

Also, add a new preferences panel called "Appearance" to allow setting
the dark mode setting, and transparent titlebar as well. Setting it will
refresh all Vim windows immediately for feedback.

Also, when setting titlebars to transparent, also hide the file icon as
it's distracting in what's a more minimalistic display. Don't use
another preference for that for now to avoid having too many options.

Minor: Remove preference panel's cross-fade effect as it's more
distracting than useful.

Fix macvim-dev#912

Also:
- See macvim-dev#1015 for part of the contribution.
- Close macvim-dev#266
- Close macvim-dev#933
@ychin ychin modified the milestones: Backlog, snapshot-164 Apr 13, 2020
ychin added a commit that referenced this issue Aug 13, 2020
Vim patch 8.2.1424

Features

- New "Appearance" option pane (accessible via Cmd-, or MacVim ->
  Preferences) to allow customizing how MacVim looks. Users can now
  select how MacVim works with Dark Mode, and configure titlebar to be
  hidden or transparent. #912 #1038 #1056
- MacVim localization support. It now uses translated Vim messages for
  the specified locale. See `:help multilang-messages` to see how to
  configure it. #991

General:

- Python is now built against 3.8, up from 3.7. #1012

Fixes:

- Fix mvim:// protocol handler behavior. Reverts behavior back to old
  behavior (before snapshot-162), but add new fallback handling to try
  to handle poorly formed URLs that don't double-encode special
  characters. See `:help macvim://`. #1055
- Can now change tabs using menu and keyboard shortcuts (Cmd-{ / Cmd-} /
  Cmd-T) when in terminal mode. #1045

Targets macOS 10.9+

Script interfaces have compatibility with these versions:
- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.8
- Ruby 2.7
ychin added a commit to ychin/macvim that referenced this issue Aug 15, 2020
Vim patch 8.2.1456

Features

- New "Appearance" option pane (accessible via Cmd-, or MacVim ->
  Preferences) to allow customizing how MacVim looks. Users can now
  select how MacVim works with Dark Mode, and configure titlebar to be
  hidden or transparent. macvim-dev#912 macvim-dev#1038 macvim-dev#1056
- MacVim localization support. It now uses translated Vim messages for
  the specified locale. See `:help multilang-messages` to see how to
  configure it. macvim-dev#991

General:

- Python is now built against 3.8, up from 3.7. macvim-dev#1012

Fixes:

- Fix mvim:// protocol handler behavior. Reverts behavior back to old
  behavior (before snapshot-162), but add new fallback handling to try
  to handle poorly formed URLs that don't double-encode special
  characters. See `:help macvim://`. macvim-dev#1055
- Can now change tabs using menu and keyboard shortcuts (Cmd-{ / Cmd-} /
  Cmd-T) when in terminal mode. macvim-dev#1045
- Fix crash during MacVim launch in Snapshot 164 (8.2.1424) due to
  dynamic library linkage. macvim-dev#1073

Targets macOS 10.9+

Script interfaces have compatibility with these versions:

- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.8
- Ruby 2.7
ychin added a commit that referenced this issue Aug 15, 2020
Vim patch 8.2.1456

Features

- New "Appearance" option pane (accessible via Cmd-, or MacVim ->
  Preferences) to allow customizing how MacVim looks. Users can now
  select how MacVim works with Dark Mode, and configure titlebar to be
  hidden or transparent. #912 #1038 #1056
- MacVim localization support. It now uses translated Vim messages for
  the specified locale. See `:help multilang-messages` to see how to
  configure it. #991

General:

- Python is now built against 3.8, up from 3.7. #1012

Fixes:

- Fix mvim:// protocol handler behavior. Reverts behavior back to old
  behavior (before snapshot-162), but add new fallback handling to try
  to handle poorly formed URLs that don't double-encode special
  characters. See `:help macvim://`. #1055
- Can now change tabs using menu and keyboard shortcuts (Cmd-{ / Cmd-} /
  Cmd-T) when in terminal mode. #1045
- Fix crash during MacVim launch in Snapshot 164 (8.2.1424) due to
  dynamic library linkage. #1073

Targets macOS 10.9+

Script interfaces have compatibility with these versions:

- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.8
- Ruby 2.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant