Skip to content

WinBar adds another MacVim menu in the menu bar #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lifepillar opened this issue Jun 29, 2019 · 7 comments · Fixed by #1126
Closed

WinBar adds another MacVim menu in the menu bar #918

lifepillar opened this issue Jun 29, 2019 · 7 comments · Fixed by #1126
Milestone

Comments

@lifepillar
Copy link
Contributor

If a window toolbar (:help WinBar) is added to a window, an additional MacVim menu appears in the app's menu bar (see screenshot below).

Detailed steps to reproduce the behavior:

  1. gvim --clean
  2. :nnoremenu 1.10 WinBar.Foo :Bar<cr>

I would expect that the window toolbar does not affect the app's menu bar. Alternatively, if a window toolbar is supposed to be replicated in the menu bar, it should be on the far right with a proper name (WinBar?) and its menu entries should be working.

macvim-toolbar-menu

  • Vim 8.1.1517
  • macOS 10.14.5
@eirnym
Copy link
Contributor

eirnym commented Jul 1, 2019

Where have you got gvim from MacVim distribution?

@eirnym
Copy link
Contributor

eirnym commented Jul 2, 2019

Btw, the step 2 is reproducable.

@lifepillar
Copy link
Contributor Author

Where have you got gvim from MacVim distribution?

I install MacVim with brew install macvim. The Homebrew formula creates that symlink:

# Create MacVim vimdiff, view, ex equivalents
executables = %w[mvimdiff mview mvimex gvim gvimdiff gview gvimex]
executables += %w[vi vim vimdiff view vimex]
executables.each { |e| bin.install_symlink "mvim" => e }

So, it's just a symlink to mvim:

ls -l `which gvim`
lrwxr-xr-x  1 me  admin  42 Jun 11 20:51 /usr/local/bin/gvim -> /Applications/MacVim.app/Contents/bin/mvim

@eirnym
Copy link
Contributor

eirnym commented Jul 2, 2019

I think it's a bad idea as gvim and mvim are different by nature. People expect to see GTK Vim instead of MacVim. I'd filed an issue to that formula on this.

@lifepillar
Copy link
Contributor Author

I don't know, MacVim is the only GUI Vim I use. I'd just note that in MacVim's app bundle, under Contents/bin one finds gview, gvim and gvimdiff as well.

@eirnym
Copy link
Contributor

eirnym commented Jul 3, 2019

My bad, I see symlinks. Didn't know that they appeared. a while ago there were no such symlinks. Thank you for an issue

@ychin
Copy link
Member

ychin commented Jul 7, 2019

I think it's fine to map gvim to mvim personally. The command line flags should mostly work. But yes this is a bug that should be fixed.

@ychin ychin added this to the snapshot-157 milestone Jul 7, 2019
@ychin ychin modified the milestones: snapshot-157, snapshot-158 Jul 17, 2019
@ychin ychin modified the milestones: snapshot-158, snapshot-159 Oct 16, 2019
@ychin ychin modified the milestones: snapshot-160, snapshot-161 Oct 28, 2019
@ychin ychin modified the milestones: snapshot-162, snapshot-163 Mar 3, 2020
@ychin ychin modified the milestones: snapshot-163, Backlog Apr 11, 2020
@ychin ychin modified the milestones: Backlog, snapshot-167 Sep 21, 2020
ychin added a commit to ychin/macvim that referenced this issue Dec 7, 2020
Fix WinBar menus to not create menu items in the main menu bar.

Also, fix an off-by-one error when adding new menu items to the main
menu when adding the menus using priorities to insert them in the
middle. This also allowed adding a menu (when using index 0) that goes
before the main "MacVim" app menu which is quite wrong as the app menu
should always be the first one.

Fix macvim-dev#918
ychin added a commit that referenced this issue Dec 11, 2020
Updated to Vim 8.2.2127.

*Note*: This release doesn't natively support Apple Silicon / M1 yet, but
does work under Rosetta. See below.

Features
====================

Big Sur / macOS 11
--------------------

- MacVim now has an updated app icon (#1054), and preference pane / toolbars
  have been updated to match Big Sur's interface guidelines. (#1128)
- Fixed Touch Bar warnings when launching MacVim from the terminal.
  #1114
- SF Symbol characters will show up properly as double-width as most of
  these icons would take up more than one column. Note that these
  characters are specific to macOS and would not work in other
  platforms. #1129

Renderer / scrolling performance improvements
--------------------

The Core Text renderer has been rewritten and is now much faster!
Scrolling should not stutter and lag like before and generally it should
feel a lot smoother now. Thanks to Sidney San Martín (@s4y) for the
contribution. #858

With this change, the non-Core-Text renderer is now considered
deprecated. The old renderer is accessible either through the Preference
Pane (under Advanced) or by setting the defaults "MMRenderer" to 0. It
works for now, but it will be removed in a future update as it has known
bugs.

Menu Localization
--------------------

Menus are now localized, see `:h langmenu` for how Vim menu localization
works. You can use `set langmenu=none` to turn it off if you would like. #1099

There still exists a few menu items that are not localized, and the
general MacVim GUI is not localized as well. If you would like to help,
please use #1102 to coordinate with MacVim dev team.

Getting help / Help menu
--------------------

- Help menu's search bar now searches Vim documentation as well! See
  #1095.
- Vimtutor is now bundled with MacVim, and you can access vimtutor from
  the Help menu (#1096). There is also a link to the latest release
  notes as well (#1131).

General
====================

- This release does not contain a native universal app for Apple Silicon
  / M1 Macs yet. The release binary will still work under Rosetta, which
  should provide enough performance, but if you use Python/etc plugins,
  you need to make sure you have x86 versions of Python/etc installed
  (which is still the default for Homebrew as of this release).

  MacVim is buildable under Apple Silicon, so if you need a native
  binary, you could build it yourself by downloading the source from the
  Github repository. See #1136 for progress on releasing a universal app
  for Apple Silicon.

- MacVim has enabled the Github Discussions feature, which serves as a
  good spot for general discussions and questions. See
  #1130 and check it
  out!

Fixes
====================

- Launching MacVim from the Dock with locales that use "," for decimal
  separators now works correctly. #11 (Vim 8.2.1738)
- `WinBar` menus (which are used by plugins like vimspector) now work
  properly and don't create dummy menu items. #918
- Using `:browse tabnew` no longer crashes MacVim in terminal mode.
  #1107 (Vim 8.2.1842)

Misc
====================

- Scripting languages versions:
    - Python is now built against 3.9, up from 3.8.
    - Lua is now built against 5.4, up from 5.3.

Compatibility
====================

Requires macOS 10.9 or above.

Script interfaces have compatibility with these versions:

- Lua 5.4
- Perl 5.18
- Python2 2.7
- Python3 3.9
- Ruby 2.7
ychin added a commit that referenced this issue Dec 12, 2020
Updated to Vim 8.2.2127.

*Note*: This release doesn't natively support Apple Silicon / M1 yet, but
does work under Rosetta. See below.

Features
====================

Big Sur / macOS 11
--------------------

- MacVim now has an updated app icon (#1054), and preference pane / toolbars
  have been updated to match Big Sur's interface guidelines. (#1128)
- Fixed Touch Bar warnings when launching MacVim from the terminal.
  #1114
- SF Symbol characters will show up properly as double-width as most of
  these icons would take up more than one column. Note that these
  characters are specific to macOS and would not work in other
  platforms. #1129

Renderer / scrolling performance improvements
--------------------

The Core Text renderer has been rewritten and is now much faster!
Scrolling should not stutter and lag like before and generally it should
feel a lot smoother now. Thanks to Sidney San Martín (@s4y) for the
contribution. #858

With this change, the non-Core-Text renderer is now considered
deprecated. The old renderer is accessible either through the Preference
Pane (under Advanced) or by setting the defaults "MMRenderer" to 0. It
works for now, but it will be removed in a future update as it has known
bugs.

Menu Localization
--------------------

Menus are now localized, see `:h langmenu` for how Vim menu localization
works. You can use `set langmenu=none` to turn it off if you would like. #1099

There still exists a few menu items that are not localized, and the
general MacVim GUI is not localized as well. If you would like to help,
please use #1102 to coordinate with MacVim dev team.

Getting help / Help menu
--------------------

- Help menu's search bar now searches Vim documentation as well! See
  #1095.
- Vimtutor is now bundled with MacVim, and you can access vimtutor from
  the Help menu (#1096). There is also a link to the latest release
  notes as well (#1131).

General
====================

- This release does not contain a native universal app for Apple Silicon
  / M1 Macs yet. The release binary will still work under Rosetta, which
  should provide enough performance, but if you use Python/etc plugins,
  you need to make sure you have x86 versions of Python/etc installed
  (which is still the default for Homebrew as of this release).

  MacVim is buildable under Apple Silicon, so if you need a native
  binary, you could build it yourself by downloading the source from the
  Github repository. See #1136 for progress on releasing a universal app
  for Apple Silicon.

- MacVim has enabled the Github Discussions feature, which serves as a
  good spot for general discussions and questions. See
  #1130 and check it
  out!

Fixes
====================

- Launching MacVim from the Dock with locales that use "," for decimal
  separators now works correctly. #11 (Vim 8.2.1738)
- `WinBar` menus (which are used by plugins like vimspector) now work
  properly and don't create dummy menu items. #918
- Using `:browse tabnew` no longer crashes MacVim in terminal mode.
  #1107 (Vim 8.2.1842)

Misc
====================

- Scripting languages versions:
    - Python is now built against 3.9, up from 3.8.
    - Lua is now built against 5.4, up from 5.3.

Compatibility
====================

Requires macOS 10.9 or above.

Script interfaces have compatibility with these versions:

- Lua 5.4
- Perl 5.18
- Python2 2.7
- Python3 3.9
- Ruby 2.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants