Fix mvim:// not handling paths with spaces #1002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file URI was being url decoded and then fed to NSURL. A decoded URI doesn't conform to RFC 2396. NSURL wasn't happy with it. We avoid decoding the url. The rest of queries (both fields and values) are still decoded.
|
Hi, sorry for the late response, but I think you are missing a line to make this work. Added a comment on it. |
ychin
reviewed
Mar 1, 2020
|
Indeed, I must have missed it while copying the patch over. |
ychin
added a commit
that referenced
this pull request
Mar 3, 2020
Vim patch 8.2.319 General: - MacVim is now upgraded to Vim 8.2! Fixes: - Fix mvim:// protocol handler to handle spaces in file names. #1002 - Allow the fullscreen toggle on the Touch Bar to be disabled. #997 - Fixed potential infinite recursion draw crash. #985 Targets macOS 10.9+ Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.7 - Ruby 2.7
frarees
added a commit
to frarees/macvim
that referenced
this pull request
Mar 11, 2020
PR macvim-dev#1002 removed decoding of the mvim:// url query. Every query goes through decoding now, no exceptions.
Merged
frarees
added a commit
to frarees/macvim
that referenced
this pull request
Mar 12, 2020
PR macvim-dev#1002 removed decoding of the mvim:// url query. Every query goes through decoding now, no exceptions.
frarees
added a commit
to frarees/macvim
that referenced
this pull request
Mar 12, 2020
PR macvim-dev#1002 removed decoding of the mvim:// url query. Every query goes through decoding now, no exceptions.
|
Hi. I used to open files on Macvim just using the cmd+click on a filename on iTerm. When the clickable filename has the line number (example: "~/projects/myproject.txt:10"), Macvim used to open the file on the exact line number. It's broken on snapshot 162. Do you think it's related with this PR? |
|
@dx7 it'll be fixed in 163, and will be released this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file URI was being url decoded and then fed to NSURL.
A decoded URI doesn't conform to RFC 2396. NSURL wasn't happy with it.
We avoid decoding the url. The rest of queries (both fields and values)
are still decoded.