Fix scrollbar to update properly when switching Vim windows #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, showing/hiding scrollbars didn't call placeScrollbars which was why sometimes when certain Vim commands that would show/hide Vim scrollbars get called, the scrollbar positions/sizes were not updated properly, leaving them with the wrong size. Fix this by adding a new pending flag so placeScrollbars only gets called once per update, and make sure showing/hiding scrollbars call it. Fix macvim-dev#802
ychin
added a commit
to ychin/macvim
that referenced
this pull request
Feb 4, 2019
Vim patch 8.1.873 Targets macOS 10.8+ General: - MacVim binary is now signed by a Developer ID (macvim-dev#517). This makes it easier to download and run the app without security warnings. - This also fixes an issue where invoking external programs via `:!open` was slow in Mojave. macvim-dev#763 - Ruby version has been updated from 2.5 to 2.6. Fixes: - Scrollbars are no longer misplaced when resizing window macvim-dev#827 - Fix rendering performance issues for commands (e.g. `:version`, `:echo`, or `:!`) that echo text in Mojave macvim-dev#840 - MacVim now properly asks for permission to use AppleEvent (ODB Editor Suite requires that to work) macvim-dev#822 - Fix borderless window mode in pre-Mojave versions macvim-dev#828 Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.7 - Ruby 2.6
ychin
added
the
UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, showing/hiding scrollbars didn't call placeScrollbars which was why sometimes when certain Vim commands that would show/hide Vim scrollbars get called, the scrollbar positions/sizes were not updated properly, leaving them with the wrong size.
Fix this by adding a new pending flag so placeScrollbars only gets called once per update, and make sure showing/hiding scrollbars call it.
Fix #802