Skip to content

Stubbed out function for Analytics module #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 9, 2022
Merged

Conversation

brendancol
Copy link
Contributor

@brendancol brendancol added the enhancement New feature or request label Jan 2, 2022
@brendancol brendancol requested a review from ianthomas23 January 2, 2022 04:46
@ianthomas23
Copy link
Contributor

I like this idea. Normally I would try to avoid the use of words such as summarize that have different spellings in English and American, but we already have polygonize and use of function names of the form verb_noun such as generate_terrain, so we should stick with the proposed name.

Function needs a docstring of course.

@thuydotm thuydotm changed the title WIP: Stubbed out function for Analytics module Stubbed out function for Analytics module Feb 7, 2022
@thuydotm thuydotm added the ready to merge PR is ready to merge label Feb 7, 2022
Copy link
Contributor

@ianthomas23 ianthomas23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, just a single character addition requested!

@thuydotm thuydotm merged commit 1f2282a into master Feb 9, 2022
@ianthomas23
Copy link
Contributor

Thanks @thuydotm!

@ianthomas23 ianthomas23 removed the ready to merge PR is ready to merge label Feb 9, 2022
@thuydotm thuydotm deleted the add-analytics-module branch June 1, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants