Skip to content

Fix rtx viewshed rendering blank image #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2022

Conversation

alex-soklev
Copy link
Contributor

Fix for wrong camera ray generation in viewshed.

While debugging the above issue I noticed that the raster had some sort of scaling applied to the latitude and longitude, but not to the height. I took that scale factor into account while triangulating the terrain and now Hillshade and Viewshed
produce almost identical results compared to their numpy counterparts.

image
On the first row you have:
the original terrain | numpy viewshed | cupy rtx viewshed
On the second row you have:
the original terrain | numpy hillshade | cupy rtx viewshed with shadows

@thuydotm
Copy link
Contributor

thuydotm commented Jun 1, 2022

Thanks @a7az0th, I'll merge this to the main branch and we can address the issue with discrepancy between CPU and GPU later.

@thuydotm thuydotm merged commit 701bee0 into makepath:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants