chore: Remove numpy pin, pin datashader, drop Python 3.7 #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datashader 0.15.0 removes error numpy.warnings removal: holoviz/datashader#1176
|
Datashader 0.15.0 supports Python >= 3.8: |
|
#770 considers dropping Python 3.7 support upon addition of Python 3.11 support. I'll defer to the maintainers. |
|
To accomodate Datashader 0.15.0, this pull request also drops Python 3.7 support. |
jthetzel
changed the title
thuydotm
approved these changes
Jul 10, 2023
|
Thanks @jthetzel! The new changes look good to me, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Xarray-spatial tests were failing due to datashader calling
numpy.warnings, which is removed in numpy >=1.24.0 ( #779 ). Datashader 0.15.0 removes calls tonumpy.warnings(pr: holoviz/datashader#1176 , changelog: https://github.com/holoviz/datashader/releases/tag/v0.15.0). This pull requests removes the numpy <= 1.23.4 pin in favour of a datashader >= 1.15.0 pin.Datashader requires Python >=3.8, so this also drops support for Python 3.7.